Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-08-07 Thread Stephen Boyd
Quoting Colin King (2019-07-01 09:50:20) > From: Colin Ian King > > The variable n_den is initialized however that value is never read > as n_den is re-assigned a little later in the two paths of a > following if-statement. Remove the redundant assignment. > > Addresses-Coverity: ("Unused value

Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-23 Thread Mike Looijmans
Good catch, thanks. You have my Acked-by: Mike Looijmans On 22-07-19 23:24, Stephen Boyd wrote: > Please Cc authors of drivers so they can ack/review. > > Adding Mike to take a look. > > Quoting Colin King (2019-07-01 09:50:20) >> From: Colin Ian King >> >> The variable n_den is initialized

Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-22 Thread Stephen Boyd
Quoting Christophe JAILLET (2019-07-22 15:00:24) > > I don't use it explicitly, but the suggestions I get include some git > history, so I guess that it is on by default. > > I was thinking at parsing files to see if MODULE_AUTHOR includes an email. > Ok. Feel free to write a patch. Just know t

Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-22 Thread Christophe JAILLET
Le 22/07/2019 à 23:53, Stephen Boyd a écrit : Quoting Christophe JAILLET (2019-07-22 14:43:32) Le 22/07/2019 à 23:24, Stephen Boyd a écrit : Please Cc authors of drivers so they can ack/review. Adding Mike to take a look. Quoting Colin King (2019-07-01 09:50:20) From: Colin Ian King The va

Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-22 Thread Stephen Boyd
Quoting Christophe JAILLET (2019-07-22 14:43:32) > Le 22/07/2019 à 23:24, Stephen Boyd a écrit : > > Please Cc authors of drivers so they can ack/review. > > > > Adding Mike to take a look. > > > > Quoting Colin King (2019-07-01 09:50:20) > >> From: Colin Ian King > >> > >> The variable n_den is i

Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-22 Thread Christophe JAILLET
Le 22/07/2019 à 23:24, Stephen Boyd a écrit : Please Cc authors of drivers so they can ack/review. Adding Mike to take a look. Quoting Colin King (2019-07-01 09:50:20) From: Colin Ian King The variable n_den is initialized however that value is never read as n_den is re-assigned a little lat

Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-22 Thread Stephen Boyd
Please Cc authors of drivers so they can ack/review. Adding Mike to take a look. Quoting Colin King (2019-07-01 09:50:20) > From: Colin Ian King > > The variable n_den is initialized however that value is never read > as n_den is re-assigned a little later in the two paths of a > following if-s

[PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-01 Thread Colin King
From: Colin Ian King The variable n_den is initialized however that value is never read as n_den is re-assigned a little later in the two paths of a following if-statement. Remove the redundant assignment. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/clk/clk-