Re: [PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

2021-03-02 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 2, 2021 at 10:03 AM Harry Wentland wrote: > > On 2021-03-02 9:05 a.m., Colin King wrote: > > From: Colin Ian King > > > > Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or > > SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized

Re: [PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

2021-03-02 Thread Harry Wentland
On 2021-03-02 9:05 a.m., Colin King wrote: From: Colin Ian King Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and this is checked for > 0 at the end of the function. Ret should be initialized, I believe

[PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

2021-03-02 Thread Colin King
From: Colin Ian King Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and this is checked for > 0 at the end of the function. Ret should be initialized, I believe setting it to zero is a correct default.