Re: [PATCH][next] selinux: fix allocation failure check on newpolicy->sidtab

2020-08-19 Thread Paul Moore
On Wed, Aug 19, 2020 at 6:42 AM Colin King wrote: > From: Colin Ian King > > The allocation check of newpolicy->sidtab is null checking if > newpolicy is null and not newpolicy->sidtab. Fix this. > > Addresses-Coverity: ("Logically dead code") > Fixes: c7c556f1e81b ("selinux: refactor changing bo

Re: [PATCH][next] selinux: fix allocation failure check on newpolicy->sidtab

2020-08-19 Thread Stephen Smalley
On 8/19/20 6:42 AM, Colin King wrote: From: Colin Ian King The allocation check of newpolicy->sidtab is null checking if newpolicy is null and not newpolicy->sidtab. Fix this. Addresses-Coverity: ("Logically dead code") Fixes: c7c556f1e81b ("selinux: refactor changing booleans") Signed-off-by

[PATCH][next] selinux: fix allocation failure check on newpolicy->sidtab

2020-08-19 Thread Colin King
From: Colin Ian King The allocation check of newpolicy->sidtab is null checking if newpolicy is null and not newpolicy->sidtab. Fix this. Addresses-Coverity: ("Logically dead code") Fixes: c7c556f1e81b ("selinux: refactor changing booleans") Signed-off-by: Colin Ian King --- security/selinux/s