Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-12 Thread Corentin Chary
On Fri, Jul 10, 2015 at 3:52 AM, Alex Hung wrote: > On Fri, Jul 10, 2015 at 4:52 AM, Darren Hart wrote: >> On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Rohár wrote: >>> On Monday 06 July 2015 15:43:28 Darren Hart wrote: >>> > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: >>> > > AT

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-09 Thread Alex Hung
On Fri, Jul 10, 2015 at 4:52 AM, Darren Hart wrote: > On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Rohár wrote: >> On Monday 06 July 2015 15:43:28 Darren Hart wrote: >> > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: >> > > ATK4001 is an ACPI device for wireless hotkey, similar to h

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-09 Thread Darren Hart
On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Rohár wrote: > On Monday 06 July 2015 15:43:28 Darren Hart wrote: > > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: > > > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and > > > HP are doing it. It is just ASUS who de

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-07 Thread Pali Rohár
On Monday 06 July 2015 15:43:28 Darren Hart wrote: > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: > > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and > > HP are doing it. It is just ASUS who decides LED should be controlled > > by software unlike HP whose LED i

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-06 Thread Darren Hart
On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and > HP are doing it. It is just ASUS who decides LED should be controlled > by software unlike HP whose LED is driven by hardware pins on mini > card. Alex, please ref

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-05 Thread Alex Hung
ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and HP are doing it. It is just ASUS who decides LED should be controlled by software unlike HP whose LED is driven by hardware pins on mini card. On Fri, Jul 3, 2015 at 3:25 PM, Pali Rohár wrote: > On Thursday 02 July 2015 15:10

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-03 Thread Pali Rohár
On Thursday 02 July 2015 15:10:39 Alex Hung wrote: > Thanks for the support. I will create v3 based with LED triggers. > > Just for information. ASUS's wording is as below: > > Fn+F2 can be used to turn on or off all radio capabilities in the > device (as known as airplane mode switch). I don'

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-02 Thread Alex Hung
Thanks for the support. I will create v3 based with LED triggers. Just for information. ASUS's wording is as below: Fn+F2 can be used to turn on or off all radio capabilities in the device (as known as airplane mode switch). I don't have any preferences on the name. We may use the term airpla

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-01 Thread Pali Rohár
On Wednesday 01 July 2015 00:09:41 Alex Hung wrote: > ATK4001 is an independent ACPI device, and Method(HSWC) is its method > to control LED (actually it has other functions but only LED is needed > so far). If this driver is for supporting ACPI ATK4001 device (which has couple of methods, not onl

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-30 Thread Pali Rohár
Hello, you can create new trigger and use that... On Tuesday 30 June 2015 18:09:41 Alex Hung wrote: > Thanks for the information, and I really appreciate it. > > I took a quick look at my HP laptop and it has a led as below: > > /sys/class/leds/hp::hddprotect$ cat trigger > [none] AC-online BAT0

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-30 Thread Darren Hart
On Mon, Jun 29, 2015 at 02:29:53PM +0200, Pali Rohár wrote: > On Friday 26 June 2015 23:24:10 Alex Hung wrote: > > On Fri, Jun 26, 2015 at 10:56 PM, Pali Rohár wrote: > > > Hi! > > > > > > On Wednesday 24 June 2015 10:57:51 Alex Hung wrote: > > >> ASUS introduced a new approach to handle wireless

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-30 Thread Alex Hung
Thanks for the information, and I really appreciate it. I took a quick look at my HP laptop and it has a led as below: /sys/class/leds/hp::hddprotect$ cat trigger [none] AC-online BAT0-charging-or-full BAT0-charging BAT0-full BAT0-charging-blink-full-solid usb-gadget usb-host cpu0 cpu1 cpu2 cpu3

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-30 Thread Pali Rohár
Hi! Ideally, try to touch led trigger configuration from userspace yourself, so you will see how it works. Take some machine which has some configurable led exported in /sys/class/leds/ and try to set some trigger via "trigger" entry. I think that default trigger for led device (from kernel) can

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-30 Thread Alex Hung
Pali, Thanks for comments, but will you be able to provide more details so it is more clear how this works? On Mon, Jun 29, 2015 at 8:29 PM, Pali Rohár wrote: > On Friday 26 June 2015 23:24:10 Alex Hung wrote: >> On Fri, Jun 26, 2015 at 10:56 PM, Pali Rohár wrote: >> > Hi! >> > >> > On Wednesda

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-29 Thread Pali Rohár
On Friday 26 June 2015 23:24:10 Alex Hung wrote: > On Fri, Jun 26, 2015 at 10:56 PM, Pali Rohár wrote: > > Hi! > > > > On Wednesday 24 June 2015 10:57:51 Alex Hung wrote: > >> ASUS introduced a new approach to handle wireless hotkey > >> since Windows 8. When the hotkey is pressed, BIOS generates

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-26 Thread Alex Hung
On Fri, Jun 26, 2015 at 10:56 PM, Pali Rohár wrote: > Hi! > > On Wednesday 24 June 2015 10:57:51 Alex Hung wrote: >> ASUS introduced a new approach to handle wireless hotkey >> since Windows 8. When the hotkey is pressed, BIOS generates >> a notification 0x88 to a new ACPI device, ATK4001. This

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-26 Thread Pali Rohár
Hi! On Wednesday 24 June 2015 10:57:51 Alex Hung wrote: > ASUS introduced a new approach to handle wireless hotkey > since Windows 8. When the hotkey is pressed, BIOS generates > a notification 0x88 to a new ACPI device, ATK4001. This > new driver not only translates the notification to KEY_RFKI

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-25 Thread Darren Hart
On Thu, Jun 25, 2015 at 08:58:04AM +0200, Paul Bolle wrote: > On Wed, 2015-06-24 at 10:57 +0800, Alex Hung wrote: > > --- /dev/null > > +++ b/drivers/platform/x86/asus-rbtn.c > > > +MODULE_ALIAS("acpi*:ATK4001:*"); > > This looked odd. It turned out this is the pattern that > scripts/mod/file2ali

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-24 Thread Paul Bolle
On Wed, 2015-06-24 at 10:57 +0800, Alex Hung wrote: > --- /dev/null > +++ b/drivers/platform/x86/asus-rbtn.c > +MODULE_ALIAS("acpi*:ATK4001:*"); This looked odd. It turned out this is the pattern that scripts/mod/file2alias.c::do_acpi_entry() creates. > +static const struct acpi_device_id asusr

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-24 Thread Darren Hart
On Wed, Jun 24, 2015 at 10:57:51AM +0800, Alex Hung wrote: > ASUS introduced a new approach to handle wireless hotkey > since Windows 8. When the hotkey is pressed, BIOS generates > a notification 0x88 to a new ACPI device, ATK4001. This > new driver not only translates the notification to KEY_RF

[PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-06-23 Thread Alex Hung
ASUS introduced a new approach to handle wireless hotkey since Windows 8. When the hotkey is pressed, BIOS generates a notification 0x88 to a new ACPI device, ATK4001. This new driver not only translates the notification to KEY_RFKILL but also toggles its LED accordingly. Signed-off-by: Alex Hun