Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-05-02 Thread Andi Kleen
> Most comments states Cyrix CPUs when they are using the macros. Is anything > with Cyrix 64 bit relevant? Maybe "include/asm-x86_64/processor.h" is a > simple copy of "include/asm-i386/processor.h" and nobody delete the unused > macros? It was originally deleted but later readded when the MT

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-05-02 Thread Andrew Morton
On Wed, 2 May 2007 09:16:59 +0200 Juergen Beisert <[EMAIL PROTECTED]> wrote: > > > > This clashes with Andi's "msr-index" patch: > > > > ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/msr-index > > I see. He also moves these defines to another file. Not problem where they > are. But it isn

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-05-02 Thread Juergen Beisert
Hi Andrew, On Wednesday 02 May 2007 02:48, Andrew Morton wrote: > On Mon, 30 Apr 2007 17:33:41 +0200 > > Juergen Beisert <[EMAIL PROTECTED]> wrote: > > From: Juergen Beisert <[EMAIL PROTECTED]> > > > > Replace NSC/Cyrix specific chipset access macros by inlined functions. > > With the macros a lin

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-05-01 Thread Andrew Morton
On Mon, 30 Apr 2007 17:33:41 +0200 Juergen Beisert <[EMAIL PROTECTED]> wrote: > From: Juergen Beisert <[EMAIL PROTECTED]> > > Replace NSC/Cyrix specific chipset access macros by inlined functions. > With the macros a line like this fails (and does nothing): > setCx86(CX86_CCR2, getCx86(CX86

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-04-30 Thread Mikael Pettersson
On Mon, 30 Apr 2007 17:33:41 +0200, Juergen Beisert wrote: > Replace NSC/Cyrix specific chipset access macros by inlined functions. > With the macros a line like this fails (and does nothing): > setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); > With inlined functions this line will work as exp

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-04-30 Thread Juergen Beisert
From: Juergen Beisert <[EMAIL PROTECTED]> Replace NSC/Cyrix specific chipset access macros by inlined functions. With the macros a line like this fails (and does nothing): setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); With inlined functions this line will work as expected. Note about a s

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Mikael Pettersson
On 30 Apr 2007 17:32:04 +0200, Andi Kleen wrote: > > From: Juergen Beisert <[EMAIL PROTECTED]> > > > > Replace NSC/Cyrix specific chipset access macros by inlined functions. > > With the macros a line like this fails (and does nothing): > > setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); > > Wi

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Alan Cox
On Mon, 30 Apr 2007 15:09:58 +0200 Juergen Beisert <[EMAIL PROTECTED]> wrote: > From: Juergen Beisert <[EMAIL PROTECTED]> > > Replace NSC/Cyrix specific chipset access macros by inlined functions. > With the macros a line like this fails (and does nothing): > setCx86(CX86_CCR2, getCx86(CX86

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Andi Kleen
Juergen Beisert <[EMAIL PROTECTED]> writes: > From: Juergen Beisert <[EMAIL PROTECTED]> > > Replace NSC/Cyrix specific chipset access macros by inlined functions. > With the macros a line like this fails (and does nothing): > setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); > With inlined fun

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Mikael Pettersson
On Mon, 30 Apr 2007 15:09:58 +0200, Juergen Beisert wrote: > Replace NSC/Cyrix specific chipset access macros by inlined functions. > With the macros a line like this fails (and does nothing): > setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); > With inlined functions this line will work as exp

[PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Juergen Beisert
From: Juergen Beisert <[EMAIL PROTECTED]> Replace NSC/Cyrix specific chipset access macros by inlined functions. With the macros a line like this fails (and does nothing): setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); With inlined functions this line will work as expected. Note about a s