Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Jeremy Fitzhardinge
Alan Cox wrote: > On Mon, 30 Apr 2007 11:50:09 +0100 > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > >> On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: >> >>> Otherwise non GPL modules cannot even do basic operations >>> like disabling interrupts anymore, which would be

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
On Monday 30 April 2007 16:55:48 Alan Cox wrote: > On Mon, 30 Apr 2007 11:50:09 +0100 > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: > > > > > > Otherwise non GPL modules cannot even do basic operations > > > like disabling

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Alan Cox
On Mon, 30 Apr 2007 11:50:09 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: > > > > Otherwise non GPL modules cannot even do basic operations > > like disabling interrupts anymore, which would be excessive. > > > > Longer term

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
> FWIW I think doing this first will be better, exposing _all_ to non GNU > modules will weaken whatever case we might have to take it away later. I have no problems taking it away later again. Or rather taking away the symbols where non GPL code clearly has no business messing with. I don't

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Peter Zijlstra
On Mon, 2007-04-30 at 13:19 +0200, Andi Kleen wrote: > On Monday 30 April 2007 13:15:36 Jan Engelhardt wrote: > > > > On Apr 30 2007 13:00, Andi Kleen wrote: > > >On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: > > >> On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: > > >> >

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
On Monday 30 April 2007 13:15:36 Jan Engelhardt wrote: > > On Apr 30 2007 13:00, Andi Kleen wrote: > >On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: > >> On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: > >> > > >> > Otherwise non GPL modules cannot even do basic operations

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 13:00, Andi Kleen wrote: >On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: >> On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: >> > >> > Otherwise non GPL modules cannot even do basic operations >> > like disabling interrupts anymore, which would be excessive.

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 11:50, Christoph Hellwig wrote: >On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: >> >> Otherwise non GPL modules cannot even do basic operations >> like disabling interrupts anymore, which would be excessive. >> >> Longer term should split the single structure up into

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: > On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: > > > > Otherwise non GPL modules cannot even do basic operations > > like disabling interrupts anymore, which would be excessive. > > > > Longer term should split the single

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: > > Otherwise non GPL modules cannot even do basic operations > like disabling interrupts anymore, which would be excessive. > > Longer term should split the single structure up into > internal and external symbols and not export the

[PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer term should split the single structure up into internal and external symbols and not export the internal ones at all. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> ---

[PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer term should split the single structure up into internal and external symbols and not export the internal ones at all. Signed-off-by: Andi Kleen [EMAIL PROTECTED] ---

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer term should split the single structure up into internal and external symbols and not export the internal

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer term should split the single structure up

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 11:50, Christoph Hellwig wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer term should split the single structure up into internal

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 13:00, Andi Kleen wrote: On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
On Monday 30 April 2007 13:15:36 Jan Engelhardt wrote: On Apr 30 2007 13:00, Andi Kleen wrote: On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Peter Zijlstra
On Mon, 2007-04-30 at 13:19 +0200, Andi Kleen wrote: On Monday 30 April 2007 13:15:36 Jan Engelhardt wrote: On Apr 30 2007 13:00, Andi Kleen wrote: On Monday 30 April 2007 12:50:09 Christoph Hellwig wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
FWIW I think doing this first will be better, exposing _all_ to non GNU modules will weaken whatever case we might have to take it away later. I have no problems taking it away later again. Or rather taking away the symbols where non GPL code clearly has no business messing with. I don't think

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Alan Cox
On Mon, 30 Apr 2007 11:50:09 +0100 Christoph Hellwig [EMAIL PROTECTED] wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer term should split

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Andi Kleen
On Monday 30 April 2007 16:55:48 Alan Cox wrote: On Mon, 30 Apr 2007 11:50:09 +0100 Christoph Hellwig [EMAIL PROTECTED] wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore,

Re: [PATCH] [39/40] i386: Export paravirt_ops for non GPL modules too

2007-04-30 Thread Jeremy Fitzhardinge
Alan Cox wrote: On Mon, 30 Apr 2007 11:50:09 +0100 Christoph Hellwig [EMAIL PROTECTED] wrote: On Mon, Apr 30, 2007 at 12:28:14PM +0200, Andi Kleen wrote: Otherwise non GPL modules cannot even do basic operations like disabling interrupts anymore, which would be excessive. Longer