Re: [PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-22 Thread Juergen Beisert
On Saturday 21 July 2007 14:00, Alexey Dobriyan wrote: > On Fri, Jul 20, 2007 at 05:32:53PM +0200, Andi Kleen wrote: > > --- /dev/null > > +++ linux/include/asm-i386/processor-cyrix.h > > @@ -0,0 +1,30 @@ > > +/* > > + * NSC/Cyrix CPU indexed register access. Must be inlined instead of > > + *

Re: [PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-21 Thread Andi Kleen
> Why bother with new header, just make static inline in asm/processor.h. processor.h is already far too big, some splitting up is a good thing. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-21 Thread Alexey Dobriyan
On Fri, Jul 20, 2007 at 05:32:53PM +0200, Andi Kleen wrote: > --- /dev/null > +++ linux/include/asm-i386/processor-cyrix.h > @@ -0,0 +1,30 @@ > +/* > + * NSC/Cyrix CPU indexed register access. Must be inlined instead of > + * macros to ensure correct access ordering > + * Access order is always

Re: [PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-21 Thread Alexey Dobriyan
On Fri, Jul 20, 2007 at 05:32:53PM +0200, Andi Kleen wrote: --- /dev/null +++ linux/include/asm-i386/processor-cyrix.h @@ -0,0 +1,30 @@ +/* + * NSC/Cyrix CPU indexed register access. Must be inlined instead of + * macros to ensure correct access ordering + * Access order is always 0x22

Re: [PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-21 Thread Andi Kleen
Why bother with new header, just make static inline in asm/processor.h. processor.h is already far too big, some splitting up is a good thing. -Andi - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-20 Thread Andi Kleen
From: Juergen Beisert <[EMAIL PROTECTED]> With the macros a line like this fails (and does nothing): setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); With inlined functions this line will work as expected. Note about a side effect: Seems on Geode GX1 based systems the "suspend on halt

[PATCH] [9/11] x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

2007-07-20 Thread Andi Kleen
From: Juergen Beisert [EMAIL PROTECTED] With the macros a line like this fails (and does nothing): setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); With inlined functions this line will work as expected. Note about a side effect: Seems on Geode GX1 based systems the suspend on halt power