Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-04 Thread Yoshihiro YUNOMAE
(2013/09/03 21:44), Eric W. Biederman wrote: > Yoshihiro YUNOMAE writes: > >> (2013/09/03 9:12), Eric W. Biederman wrote: >> Then again looking at the output of the latest dmesg, it seems the IO >> APIC >> is initialized way before the tsc is calibrated. So I am not sure what

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-04 Thread Yoshihiro YUNOMAE
(2013/09/03 21:44), Eric W. Biederman wrote: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes: (2013/09/03 9:12), Eric W. Biederman wrote: Then again looking at the output of the latest dmesg, it seems the IO APIC is initialized way before the tsc is calibrated. So I am not sure

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-03 Thread Eric W. Biederman
Yoshihiro YUNOMAE writes: > (2013/09/03 9:12), Eric W. Biederman wrote: > Then again looking at the output of the latest dmesg, it seems the IO APIC > is initialized way before the tsc is calibrated. So I am not sure what > needed to get done or what interrupts are needed before the

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-03 Thread Yoshihiro YUNOMAE
(2013/09/03 9:12), Eric W. Biederman wrote: Then again looking at the output of the latest dmesg, it seems the IO APIC is initialized way before the tsc is calibrated. So I am not sure what needed to get done or what interrupts are needed before the IO APIC gets initialized.

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-03 Thread Yoshihiro YUNOMAE
(2013/09/03 9:12), Eric W. Biederman wrote: Then again looking at the output of the latest dmesg, it seems the IO APIC is initialized way before the tsc is calibrated. So I am not sure what needed to get done or what interrupts are needed before the IO APIC gets initialized. The practical

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-03 Thread Eric W. Biederman
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes: (2013/09/03 9:12), Eric W. Biederman wrote: Then again looking at the output of the latest dmesg, it seems the IO APIC is initialized way before the tsc is calibrated. So I am not sure what needed to get done or what interrupts are

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-02 Thread Eric W. Biederman
Yoshihiro YUNOMAE writes: > Hi Eric and Don, > > Sorry for the late reply. > > (2013/08/31 9:58), Eric W. Biederman wrote: >> Don Zickus writes: >> >>> On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: Hi Don, Sorry for the late reply. (2013/08/22

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-02 Thread Eric W. Biederman
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes: Hi Eric and Don, Sorry for the late reply. (2013/08/31 9:58), Eric W. Biederman wrote: Don Zickus dzic...@redhat.com writes: On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: Hi Don, Sorry for the late reply.

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-01 Thread Yoshihiro YUNOMAE
Hi Eric and Don, Sorry for the late reply. (2013/08/31 9:58), Eric W. Biederman wrote: > Don Zickus writes: > >> On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: >>> Hi Don, >>> >>> Sorry for the late reply. >>> >>> (2013/08/22 22:11), Don Zickus wrote: On Thu, Aug 22,

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-09-01 Thread Yoshihiro YUNOMAE
Hi Eric and Don, Sorry for the late reply. (2013/08/31 9:58), Eric W. Biederman wrote: Don Zickus dzic...@redhat.com writes: On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: Hi Don, Sorry for the late reply. (2013/08/22 22:11), Don Zickus wrote: On Thu, Aug 22, 2013

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-30 Thread Eric W. Biederman
Don Zickus writes: > On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: >> Hi Don, >> >> Sorry for the late reply. >> >> (2013/08/22 22:11), Don Zickus wrote: >> >On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: >> >>>So, I agree with Eric, let's remove the

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-30 Thread Eric W. Biederman
Don Zickus dzic...@redhat.com writes: On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: Hi Don, Sorry for the late reply. (2013/08/22 22:11), Don Zickus wrote: On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: So, I agree with Eric, let's remove the

Re: Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-27 Thread Don Zickus
On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: > Hi Don, > > Sorry for the late reply. > > (2013/08/22 22:11), Don Zickus wrote: > >On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: > >>>So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep

Re: Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-27 Thread Don Zickus
On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: Hi Don, Sorry for the late reply. (2013/08/22 22:11), Don Zickus wrote: On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep the code

Re: Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-26 Thread Yoshihiro YUNOMAE
Hi Don, Sorry for the late reply. (2013/08/22 22:11), Don Zickus wrote: On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep the code simpler. Thank you for commenting about my patch. I didn't know you

Re: Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-26 Thread Yoshihiro YUNOMAE
Hi Don, Sorry for the late reply. (2013/08/22 22:11), Don Zickus wrote: On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep the code simpler. Thank you for commenting about my patch. I didn't know you

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-22 Thread Don Zickus
On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: > >So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep > >the code simpler. > > Thank you for commenting about my patch. > I didn't know you already have submitted the patches for this deadlock > problem. > >

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-22 Thread Yoshihiro YUNOMAE
(2013/08/20 23:27), Don Zickus wrote: On Tue, Aug 20, 2013 at 03:12:32AM -0700, Eric W. Biederman wrote: Yoshihiro YUNOMAE writes: Hi Ingo, Thank you for fixing typos! OK, I'll fix them and rename to ioapic_zap_locks(). Thank you again! The better fix for this would be to remove the

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-22 Thread Yoshihiro YUNOMAE
(2013/08/20 23:27), Don Zickus wrote: On Tue, Aug 20, 2013 at 03:12:32AM -0700, Eric W. Biederman wrote: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes: Hi Ingo, Thank you for fixing typos! OK, I'll fix them and rename to ioapic_zap_locks(). Thank you again! The better fix for

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-22 Thread Don Zickus
On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep the code simpler. Thank you for commenting about my patch. I didn't know you already have submitted the patches for this deadlock problem. I can't

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-20 Thread Don Zickus
On Tue, Aug 20, 2013 at 03:12:32AM -0700, Eric W. Biederman wrote: > Yoshihiro YUNOMAE writes: > > > Hi Ingo, > > > > Thank you for fixing typos! > > OK, I'll fix them and rename to ioapic_zap_locks(). > > > > Thank you again! > > > The better fix for this would be to remove the

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-20 Thread Eric W. Biederman
Yoshihiro YUNOMAE writes: > Hi Ingo, > > Thank you for fixing typos! > OK, I'll fix them and rename to ioapic_zap_locks(). > > Thank you again! The better fix for this would be to remove the disable_IO_APIC call from crash_kexec. I know last time it was investigated the kernel was very close

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-20 Thread Eric W. Biederman
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes: Hi Ingo, Thank you for fixing typos! OK, I'll fix them and rename to ioapic_zap_locks(). Thank you again! The better fix for this would be to remove the disable_IO_APIC call from crash_kexec. I know last time it was investigated

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-20 Thread Don Zickus
On Tue, Aug 20, 2013 at 03:12:32AM -0700, Eric W. Biederman wrote: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes: Hi Ingo, Thank you for fixing typos! OK, I'll fix them and rename to ioapic_zap_locks(). Thank you again! The better fix for this would be to remove the

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-19 Thread Yoshihiro YUNOMAE
Hi Ingo, Thank you for fixing typos! OK, I'll fix them and rename to ioapic_zap_locks(). Thank you again! Yoshihiro YUNOMAE (2013/08/19 18:46), Ingo Molnar wrote: * Yoshihiro YUNOMAE wrote: Prevent crash_kexec() from deadlocking of ioapic_lock. s/of/on When crash_kexec() is executed

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-19 Thread Ingo Molnar
* Yoshihiro YUNOMAE wrote: > Prevent crash_kexec() from deadlocking of ioapic_lock. s/of/on > When crash_kexec() is executed on a cpu, the cpu will get > ioapic_lock in disable_IO_APIC(). So if the cpu gets NMI > while locking ioapic_lock, a deadlock wiil happen. In s/will > this patch,

[PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-19 Thread Yoshihiro YUNOMAE
Prevent crash_kexec() from deadlocking of ioapic_lock. When crash_kexec() is executed on a cpu, the cpu will get ioapic_lock in disable_IO_APIC(). So if the cpu gets NMI while locking ioapic_lock, a deadlock wiil happen. In this patch, ioapic_lock is initialized before disable_IO_APIC(). To

[PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-19 Thread Yoshihiro YUNOMAE
Prevent crash_kexec() from deadlocking of ioapic_lock. When crash_kexec() is executed on a cpu, the cpu will get ioapic_lock in disable_IO_APIC(). So if the cpu gets NMI while locking ioapic_lock, a deadlock wiil happen. In this patch, ioapic_lock is initialized before disable_IO_APIC(). To

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-19 Thread Ingo Molnar
* Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: Prevent crash_kexec() from deadlocking of ioapic_lock. s/of/on When crash_kexec() is executed on a cpu, the cpu will get ioapic_lock in disable_IO_APIC(). So if the cpu gets NMI while locking ioapic_lock, a deadlock wiil

Re: Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-19 Thread Yoshihiro YUNOMAE
Hi Ingo, Thank you for fixing typos! OK, I'll fix them and rename to ioapic_zap_locks(). Thank you again! Yoshihiro YUNOMAE (2013/08/19 18:46), Ingo Molnar wrote: * Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: Prevent crash_kexec() from deadlocking of ioapic_lock. s/of/on