Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-14 Thread David Miller
From: Ravikiran G Thirumalai <[EMAIL PROTECTED]> Date: Wed, 14 Mar 2007 13:15:42 -0700 > The kernel bugzilla shows zaroo boogs for multipath cached as well. Because _EVERYBODY_ turns it off because we tell them to do so! Every bug reported to the lists is replied to with "that code is

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-14 Thread Ravikiran G Thirumalai
On Mon, Mar 12, 2007 at 01:56:13PM -0700, David Miller wrote: > From: Pekka J Enberg <[EMAIL PROTECTED]> > Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET) > > > On 3/9/07, David Miller <[EMAIL PROTECTED]> wrote: > > > The whole cahce-multipath subsystem has to have it's guts revamped for > > > proper

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-14 Thread Ravikiran G Thirumalai
On Mon, Mar 12, 2007 at 01:56:13PM -0700, David Miller wrote: From: Pekka J Enberg [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET) On 3/9/07, David Miller [EMAIL PROTECTED] wrote: The whole cahce-multipath subsystem has to have it's guts revamped for proper error

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-14 Thread David Miller
From: Ravikiran G Thirumalai [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 13:15:42 -0700 The kernel bugzilla shows zaroo boogs for multipath cached as well. Because _EVERYBODY_ turns it off because we tell them to do so! Every bug reported to the lists is replied to with that code is unbelievably

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-13 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 10:22:36PM -0800, Andrew Morton wrote: > > On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > > wrote: ... > > And there is absolutely no negotiations about this, I've held back on > > this for nearly 2 years, and nothing has happened, this code is

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-13 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 10:22:36PM -0800, Andrew Morton wrote: On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: ... And there is absolutely no negotiations about this, I've held back on this for nearly 2 years, and nothing has happened, this code is not

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread Andrew Morton
> On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Mon, 12 Mar 2007 12:51:37 +0100 > > > But until then it'll unnecessarily spoil linux opinion as regards > > stability and waste time of developers to check

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread David Miller
From: "Pekka Enberg" <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 14:36:46 +0200 > On 3/12/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > So, maybe it's less evil to check those NULLs where possible and add > > some WARN_ONs here and there... > > No, it's much better to oops rather than paper

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread David Miller
From: Pekka J Enberg <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET) > On 3/9/07, David Miller <[EMAIL PROTECTED]> wrote: > > The whole cahce-multipath subsystem has to have it's guts revamped for > > proper error handling. > > (Untested patch follows.) I'm not accepting

Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 12:51:37 +0100 > But until then it'll unnecessarily spoil linux opinion as regards > stability and waste time of developers to check error messages. > So, maybe it's less evil to check those NULLs where possible and add > some

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 02:36:46PM +0200, Pekka Enberg wrote: > On 3/12/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > >So, maybe it's less evil to check those NULLs where possible and add > >some WARN_ONs here and there... > > No, it's much better to oops rather than paper over a bug. > I'm

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka Enberg
On 3/12/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka J Enberg
On 3/9/07, David Miller <[EMAIL PROTECTED]> wrote: > The whole cahce-multipath subsystem has to have it's guts revamped for > proper error handling. (Untested patch follows.) From: Amit Choudhary <[EMAIL PROTECTED]> Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Jarek Poplawski
On 09-03-2007 08:29, David Miller wrote: > From: Amit Choudhary <[EMAIL PROTECTED]> > Date: Thu, 8 Mar 2007 23:22:15 -0800 > >> Description: Check the return value of kmalloc() in function >> wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. >> >> Signed-off-by: Amit Choudhary <[EMAIL

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Jarek Poplawski
On 09-03-2007 08:29, David Miller wrote: From: Amit Choudhary [EMAIL PROTECTED] Date: Thu, 8 Mar 2007 23:22:15 -0800 Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. Signed-off-by: Amit Choudhary [EMAIL PROTECTED]

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka J Enberg
On 3/9/07, David Miller [EMAIL PROTECTED] wrote: The whole cahce-multipath subsystem has to have it's guts revamped for proper error handling. (Untested patch follows.) From: Amit Choudhary [EMAIL PROTECTED] Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka Enberg
On 3/12/07, Jarek Poplawski [EMAIL PROTECTED] wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 02:36:46PM +0200, Pekka Enberg wrote: On 3/12/07, Jarek Poplawski [EMAIL PROTECTED] wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug. I'm not sure I

Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 12:51:37 +0100 But until then it'll unnecessarily spoil linux opinion as regards stability and waste time of developers to check error messages. So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread David Miller
From: Pekka Enberg [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:36:46 +0200 On 3/12/07, Jarek Poplawski [EMAIL PROTECTED] wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug.

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread David Miller
From: Pekka J Enberg [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET) On 3/9/07, David Miller [EMAIL PROTECTED] wrote: The whole cahce-multipath subsystem has to have it's guts revamped for proper error handling. (Untested patch follows.) I'm not accepting untested patches,

Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread Andrew Morton
On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 12:51:37 +0100 But until then it'll unnecessarily spoil linux opinion as regards stability and waste time of developers to check error messages.

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-08 Thread David Miller
From: Amit Choudhary <[EMAIL PROTECTED]> Date: Thu, 8 Mar 2007 23:22:15 -0800 > Description: Check the return value of kmalloc() in function > wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. > > Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> This kind of patch has been submitted

[PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-08 Thread Amit Choudhary
Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> diff --git a/net/ipv4/multipath_wrandom.c b/net/ipv4/multipath_wrandom.c index 92b0482..bcdb1f1 100644 ---

[PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-08 Thread Amit Choudhary
Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. Signed-off-by: Amit Choudhary [EMAIL PROTECTED] diff --git a/net/ipv4/multipath_wrandom.c b/net/ipv4/multipath_wrandom.c index 92b0482..bcdb1f1 100644 ---

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-08 Thread David Miller
From: Amit Choudhary [EMAIL PROTECTED] Date: Thu, 8 Mar 2007 23:22:15 -0800 Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. Signed-off-by: Amit Choudhary [EMAIL PROTECTED] This kind of patch has been submitted several