Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-07 Thread Daniel Vetter
On Fri, Mar 7, 2014 at 4:28 AM, Rusty Russell wrote: >>> If this is a good idea, you can write a macro module_param_unsafe_named >>> which is a general wrapper. >> >> For this to work I need to somehow store the safe default value somewhere. >> since with bools or strings there really isn't such

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-07 Thread Daniel Vetter
On Fri, Mar 7, 2014 at 4:28 AM, Rusty Russell ru...@rustcorp.com.au wrote: If this is a good idea, you can write a macro module_param_unsafe_named which is a general wrapper. For this to work I need to somehow store the safe default value somewhere. since with bools or strings there really

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-06 Thread Rusty Russell
Daniel Vetter writes: > On Thu, Mar 06, 2014 at 11:19:54AM +1030, Rusty Russell wrote: >> Daniel Vetter writes: >> > Users just love to set random piles of options since surely enabling >> > all the experimental stuff helps. Later on we get bug reports because >> > it all fell apart. >> > >> >

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-06 Thread Rusty Russell
Daniel Vetter dan...@ffwll.ch writes: On Thu, Mar 06, 2014 at 11:19:54AM +1030, Rusty Russell wrote: Daniel Vetter daniel.vet...@ffwll.ch writes: Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
On Thu, Mar 06, 2014 at 11:19:54AM +1030, Rusty Russell wrote: > Daniel Vetter writes: > > Users just love to set random piles of options since surely enabling > > all the experimental stuff helps. Later on we get bug reports because > > it all fell apart. > > > > Even more fun when it's labelled

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Rusty Russell
Daniel Vetter writes: > Users just love to set random piles of options since surely enabling > all the experimental stuff helps. Later on we get bug reports because > it all fell apart. > > Even more fun when it's labelled a regression when some change only > just made the feature possible (e.g.

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
On Wed, Mar 5, 2014 at 10:00 PM, Daniel Vetter wrote: > On Wed, Mar 5, 2014 at 9:32 PM, Andrew Morton > wrote: >> On Wed, 5 Mar 2014 10:33:14 +0100 Daniel Vetter >> wrote: >> >>> Users just love to set random piles of options since surely enabling >>> all the experimental stuff helps. Later

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
On Wed, Mar 5, 2014 at 9:32 PM, Andrew Morton wrote: > On Wed, 5 Mar 2014 10:33:14 +0100 Daniel Vetter > wrote: > >> Users just love to set random piles of options since surely enabling >> all the experimental stuff helps. Later on we get bug reports because >> it all fell apart. >> >> Even

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Andrew Morton
On Wed, 5 Mar 2014 10:33:14 +0100 Daniel Vetter wrote: > Users just love to set random piles of options since surely enabling > all the experimental stuff helps. Later on we get bug reports because > it all fell apart. > > Even more fun when it's labelled a regression when some change only >

[PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it all fell apart. Even more fun when it's labelled a regression when some change only just made the feature possible (e.g. stolen memory fixes suddenly

[PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it all fell apart. Even more fun when it's labelled a regression when some change only just made the feature possible (e.g. stolen memory fixes suddenly

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Andrew Morton
On Wed, 5 Mar 2014 10:33:14 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it all fell apart. Even more fun when it's labelled a regression when

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
On Wed, Mar 5, 2014 at 9:32 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 5 Mar 2014 10:33:14 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
On Wed, Mar 5, 2014 at 10:00 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Wed, Mar 5, 2014 at 9:32 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 5 Mar 2014 10:33:14 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: Users just love to set random piles of options since

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Rusty Russell
Daniel Vetter daniel.vet...@ffwll.ch writes: Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it all fell apart. Even more fun when it's labelled a regression when some change only just made the feature

Re: [PATCH] [RFC] Taint the kernel for unsafe module options

2014-03-05 Thread Daniel Vetter
On Thu, Mar 06, 2014 at 11:19:54AM +1030, Rusty Russell wrote: Daniel Vetter daniel.vet...@ffwll.ch writes: Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it all fell apart. Even more fun when