Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-11 Thread Konrad Rzeszutek Wilk
On Wed, Dec 11, 2013 at 12:18:19PM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 10, 2013 at 12:46:36PM -0600, Mike Christie wrote: > > On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: > > >Ethan Zhao wrote: > > >>Konrad, > > >> > > >>boot_kset was allocated when module loaded by > >

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-11 Thread Konrad Rzeszutek Wilk
On Tue, Dec 10, 2013 at 12:46:36PM -0600, Mike Christie wrote: > On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: > >Ethan Zhao wrote: > >>Konrad, > >> > >>boot_kset was allocated when module loaded by > >>ibft_init() > >> iscsi_boot_create_kset() > >> kzalloc() > >> > >>but wasn't freed

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-11 Thread Konrad Rzeszutek Wilk
On Tue, Dec 10, 2013 at 12:46:36PM -0600, Mike Christie wrote: On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-11 Thread Konrad Rzeszutek Wilk
On Wed, Dec 11, 2013 at 12:18:19PM -0500, Konrad Rzeszutek Wilk wrote: On Tue, Dec 10, 2013 at 12:46:36PM -0600, Mike Christie wrote: On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 10:11 PM, Konrad Rzeszutek Wilk wrote: > Ethan Zhao wrote: >>Konrad, >> >> boot_kset was allocated when module loaded by >>ibft_init() >> iscsi_boot_create_kset() >> kzalloc() >> >>but wasn't freed when module unloaded by >>ibft_exit() >> ibft_cleanup() >>

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Mike Christie
On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: Ethan Zhao wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit() ibft_cleanup() iscsi_boot_destroy_kset() Thanks, Ethan

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Konrad Rzeszutek Wilk
Ethan Zhao wrote: >Konrad, > > boot_kset was allocated when module loaded by >ibft_init() > iscsi_boot_create_kset() > kzalloc() > >but wasn't freed when module unloaded by >ibft_exit() > ibft_cleanup() > iscsi_boot_destroy_kset() > >Thanks, >Ethan > >On Tue, Dec 10, 2013 at 5:30 AM,

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Mike Christie
On 12/10/13 8:11 AM, Konrad Rzeszutek Wilk wrote: Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit() ibft_cleanup()

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 10:11 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit()

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-10 Thread Konrad Rzeszutek Wilk
Ethan Zhao ethan.ker...@gmail.com wrote: Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit() ibft_cleanup() iscsi_boot_destroy_kset() Thanks, Ethan On Tue, Dec 10, 2013 at 5:30

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Ethan Zhao
Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit() ibft_cleanup() iscsi_boot_destroy_kset() Thanks, Ethan On Tue, Dec 10, 2013 at 5:30 AM, Konrad Rzeszutek Wilk wrote: > On

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Mike Christie
On 12/09/2013 03:37 AM, Ethan Zhao wrote: > From: "Ethan Zhao" > > Load and unload iscsi_ibft module will cause kernel memory leak, fix it > in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). > > Signed-off-by: Ethan Zhao > --- > drivers/scsi/iscsi_boot_sysfs.c | 1 + > 1 file changed, 1

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Konrad Rzeszutek Wilk
On Mon, Dec 09, 2013 at 05:37:11PM +0800, Ethan Zhao wrote: > From: "Ethan Zhao" > > Load and unload iscsi_ibft module will cause kernel memory leak, fix it > in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). > Is there a stack trace? > Signed-off-by: Ethan Zhao > --- >

[PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Ethan Zhao
From: "Ethan Zhao" Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Signed-off-by: Ethan Zhao --- drivers/scsi/iscsi_boot_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/iscsi_boot_sysfs.c

[PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Ethan Zhao
From: Ethan Zhao ethan.ker...@gmail.com Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Signed-off-by: Ethan Zhao ethan.ker...@gmail.com --- drivers/scsi/iscsi_boot_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Konrad Rzeszutek Wilk
On Mon, Dec 09, 2013 at 05:37:11PM +0800, Ethan Zhao wrote: From: Ethan Zhao ethan.ker...@gmail.com Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Is there a stack trace? Signed-off-by: Ethan Zhao

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Mike Christie
On 12/09/2013 03:37 AM, Ethan Zhao wrote: From: Ethan Zhao ethan.ker...@gmail.com Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Signed-off-by: Ethan Zhao ethan.ker...@gmail.com ---

Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-09 Thread Ethan Zhao
Konrad, boot_kset was allocated when module loaded by ibft_init() iscsi_boot_create_kset() kzalloc() but wasn't freed when module unloaded by ibft_exit() ibft_cleanup() iscsi_boot_destroy_kset() Thanks, Ethan On Tue, Dec 10, 2013 at 5:30 AM, Konrad Rzeszutek Wilk