Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-26 Thread isely
Acked-by: Mike Isely On Mon, 26 Aug 2019, Yizhuo wrote: > Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag > will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. > However, it will be used in the later if statement, which is > potentially unsafe. > > Signed-off-by: Yizhuo >

[PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-26 Thread Yizhuo
Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. However, it will be used in the later if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 2 +- 1 file changed, 1

Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-26 Thread Yizhuo Zhai
Thanks for the correction, let me send a new patch then. On Mon, Aug 26, 2019 at 5:09 AM Hans Verkuil wrote: > > On 8/21/19 11:09 PM, Yizhuo wrote: > > Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag > > will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. > > However, it will be

Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-26 Thread Hans Verkuil
On 8/21/19 11:09 PM, Yizhuo wrote: > Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag > will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. > However, it will be used in the later if statement, which is > potentially unsafe. > > Signed-off-by: Yizhuo > --- >

Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-25 Thread isely
Acked-by: Mike Isely On Wed, 21 Aug 2019, Yizhuo wrote: > Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag > will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. > However, it will be used in the later if statement, which is > potentially unsafe. > > Signed-off-by: Yizhuo >

Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-22 Thread kbuild test robot
Hi Yizhuo, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [cannot apply to v5.3-rc5 next-20190822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

2019-08-21 Thread Yizhuo
Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. However, it will be used in the later if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 + 1 file changed, 1