Re: [PATCH] [net/ethtool] ethnl_set_linkmodes: remove redundant null check

2020-08-03 Thread David Miller
From: Gaurav Singh Date: Fri, 31 Jul 2020 00:58:44 -0400 > info cannot be NULL here since its being accessed earlier > in the function: nlmsg_parse(info->nlhdr...). Remove this > redundant NULL check. > > Signed-off-by: Gaurav Singh Applied, thank you.

Re: [PATCH] [net/ethtool] ethnl_set_linkmodes: remove redundant null check

2020-07-31 Thread Michal Kubecek
On Fri, Jul 31, 2020 at 12:58:44AM -0400, Gaurav Singh wrote: > info cannot be NULL here since its being accessed earlier > in the function: nlmsg_parse(info->nlhdr...). Remove this > redundant NULL check. This is what the static checker tells you but it could still mean the other place is

[PATCH] [net/ethtool] ethnl_set_linkmodes: remove redundant null check

2020-07-30 Thread Gaurav Singh
info cannot be NULL here since its being accessed earlier in the function: nlmsg_parse(info->nlhdr...). Remove this redundant NULL check. Signed-off-by: Gaurav Singh --- net/ethtool/linkmodes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ethtool/linkmodes.c