Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Scott Wood
On Fri, Jul 20, 2007 at 12:57:02AM -0700, Andrew Morton wrote: > On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > > On Thu, 19 Jul 2007 23:23:37 -0700 > > Andrew Morton wrote: > > > Shouldn't these be runtime options (ie: module parameters)? > > > > > I thought about

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > On Thu, 19 Jul 2007 23:23:37 -0700 > Andrew Morton wrote: > > > On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug > > <[EMAIL PROTECTED]> wrote: > > > > > > > > device_bind_driver() error code returning has been

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Vitaly Bordug
On Thu, 19 Jul 2007 23:23:37 -0700 Andrew Morton wrote: > On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug > <[EMAIL PROTECTED]> wrote: > > > > > device_bind_driver() error code returning has been fixed. > > release() function has been written, so that to free resources > > in correct way;

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Andrew Morton
On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > > device_bind_driver() error code returning has been fixed. > release() function has been written, so that to free resources > in correct way; the release path is now clean. > > Before the rework, it used to

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Scott Wood
On Fri, Jul 20, 2007 at 12:57:02AM -0700, Andrew Morton wrote: On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: On Thu, 19 Jul 2007 23:23:37 -0700 Andrew Morton wrote: Shouldn't these be runtime options (ie: module parameters)? I thought about it but this

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Andrew Morton
On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Vitaly Bordug
On Thu, 19 Jul 2007 23:23:37 -0700 Andrew Morton wrote: On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: On Thu, 19 Jul 2007 23:23:37 -0700 Andrew Morton wrote: On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug [EMAIL PROTECTED] wrote: device_bind_driver() error code returning has been fixed. release()

[PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and

[PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and