Re: [PATCH] [v2] ethtool: reduce stack usage with clang

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 6:46 PM David Miller wrote: > > From: Arnd Bergmann > Date: Thu, 7 Mar 2019 16:58:35 +0100 > > > clang inlines the dev_ethtool() more aggressively than gcc does, leading > > to a larger amount of used stack space: > > > > net/core/ethtool.c:2536:24: error: stack frame

Re: [PATCH] [v2] ethtool: reduce stack usage with clang

2019-03-07 Thread David Miller
From: Arnd Bergmann Date: Thu, 7 Mar 2019 16:58:35 +0100 > clang inlines the dev_ethtool() more aggressively than gcc does, leading > to a larger amount of used stack space: > > net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function > 'dev_ethtool'

Re: [PATCH] [v2] ethtool: reduce stack usage with clang

2019-03-07 Thread Michal Kubecek
On Thu, Mar 07, 2019 at 04:58:35PM +0100, Arnd Bergmann wrote: > clang inlines the dev_ethtool() more aggressively than gcc does, leading > to a larger amount of used stack space: > > net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function > 'dev_ethtool'

[PATCH] [v2] ethtool: reduce stack usage with clang

2019-03-07 Thread Arnd Bergmann
clang inlines the dev_ethtool() more aggressively than gcc does, leading to a larger amount of used stack space: net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function 'dev_ethtool' [-Werror,-Wframe-larger-than=] Marking the sub-functions that require the most stack space