Re: Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread dinghao . liu
Sorry, I misunderstood your idea before. A new function is the best solution for this problem. Regards, Dinghao Dan Carpenter dan.carpen...@oracle.com写道: > On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote: > > We need to make sure if pm_runtime_get_sync() is designed with

Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Dan Carpenter
On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote: > We need to make sure if pm_runtime_get_sync() is designed with > such behavior before modifying it. > > I received a response from Rafael when I commited a similar patch: > https://lkml.org/lkml/2020/5/20/1100 > It seems

Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread dinghao . liu
We need to make sure if pm_runtime_get_sync() is designed with such behavior before modifying it. I received a response from Rafael when I commited a similar patch: https://lkml.org/lkml/2020/5/20/1100 It seems that this behavior is intentional and needs to be kept. Regards, Dinghao Dan

Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Dan Carpenter
On Thu, May 21, 2020 at 02:27:45PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu Let's

[PATCH] [v2] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove unused label 'unlock' ---