Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-17 Thread Yu Chen
On 08/11/2015 10:45 AM, Darren Hart wrote: On Fri, Aug 07, 2015 at 08:48:18AM +, Chen, Yu C wrote: On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: \ I think the older switch/case was easier to

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-17 Thread Yu Chen
On 08/11/2015 10:45 AM, Darren Hart wrote: On Fri, Aug 07, 2015 at 08:48:18AM +, Chen, Yu C wrote: On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: \ I think the older switch/case was easier to

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-10 Thread Darren Hart
On Fri, Aug 07, 2015 at 08:48:18AM +, Chen, Yu C wrote: > On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: > > On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: > > \ > > > + ret;\ > > > +}) > > > >

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-10 Thread Darren Hart
On Fri, Aug 07, 2015 at 08:48:18AM +, Chen, Yu C wrote: On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: \ + ret;\ +}) This seems a bit

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-07 Thread Chen, Yu C
On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: > On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: > \ > > + ret;\ > > +}) > > This seems a bit complicated. > > The else ret = 0 isn't necessary as

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-07 Thread Joe Perches
On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can > not detect these buttons on it. The comments below are all just style trivia and can be ignored

[PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-07 Thread Chen Yu
Since Surface Pro 3 does not follow the specs of "Windows ACPI Design Guide for SoC Platform", code in drivers/input/misc/soc_array.c can not detect these buttons on it. According to bios implementation, Surface Pro 3 encapsulates these buttons in a device named "VGBI", with _HID "MSHW0028". When

[PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-07 Thread Chen Yu
Since Surface Pro 3 does not follow the specs of Windows ACPI Design Guide for SoC Platform, code in drivers/input/misc/soc_array.c can not detect these buttons on it. According to bios implementation, Surface Pro 3 encapsulates these buttons in a device named VGBI, with _HID MSHW0028. When any of

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-07 Thread Joe Perches
On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: Since Surface Pro 3 does not follow the specs of Windows ACPI Design Guide for SoC Platform, code in drivers/input/misc/soc_array.c can not detect these buttons on it. The comments below are all just style trivia and can be ignored entirely.

Re: [PATCH] [v2] surface pro 3: Add support driver for Surface Pro 3 buttons

2015-08-07 Thread Chen, Yu C
On Fri, 2015-08-07 at 01:27 -0700, Joe Perches wrote: On Fri, 2015-08-07 at 15:57 +0800, Chen Yu wrote: \ + ret;\ +}) This seems a bit complicated. The else ret = 0 isn't necessary as it's