Re: [PATCH] arm/mach-omap2/display: fix possible object reference leak

2019-02-19 Thread Tony Lindgren
* Julia Lawall [190219 17:33]: > On Tue, 19 Feb 2019, Tony Lindgren wrote: > > In general, if the device tree node is never used afterwards, > > should this be just: > > > > r = of_platform_populate(node, NULL, NULL, &pdev->dev); > > of_node_put(dev_node); > > if (r) { > >

Re: [PATCH] arm/mach-omap2/display: fix possible object reference leak

2019-02-19 Thread Julia Lawall
On Tue, 19 Feb 2019, Tony Lindgren wrote: > Hi, > > Adding devicetree list, Julia, Rob and Tomi to Cc. > > * Peng Hao [190212 23:11]: > > of_find_device_by_node() takes a reference to the struct device > > when it finds a match via get_device.When returning error we should > > call put_device.

Re: [PATCH] arm/mach-omap2/display: fix possible object reference leak

2019-02-19 Thread Julia Lawall
On Tue, 19 Feb 2019, Tony Lindgren wrote: > Hi, > > Adding devicetree list, Julia, Rob and Tomi to Cc. > > * Peng Hao [190212 23:11]: > > of_find_device_by_node() takes a reference to the struct device > > when it finds a match via get_device.When returning error we should > > call put_device.

Re: [PATCH] arm/mach-omap2/display: fix possible object reference leak

2019-02-19 Thread Tony Lindgren
Hi, Adding devicetree list, Julia, Rob and Tomi to Cc. * Peng Hao [190212 23:11]: > of_find_device_by_node() takes a reference to the struct device > when it finds a match via get_device.When returning error we should > call put_device. > > Signed-off-by: Peng Hao > --- > arch/arm/mach-omap2/

[PATCH] arm/mach-omap2/display: fix possible object reference leak

2019-02-12 Thread Peng Hao
of_find_device_by_node() takes a reference to the struct device when it finds a match via get_device.When returning error we should call put_device. Signed-off-by: Peng Hao --- arch/arm/mach-omap2/display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/display.c b/arch/