> > printk("%s\n", version);
> >
> > Not quite as optimal but safer.
>
> I disagree. Don't work around an escape bug in a version string, fix
> it...
A % in a version string might be quite reasonable. You are asking to have
an accident by avoiding it. If you want to fight over 4
>
> On Sat, 19 May 2001 17:58:49 -0400,
> Jeff Garzik <[EMAIL PROTECTED]> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk like
> >
> >
On Sat, 19 May 2001 17:58:49 -0400,
Jeff Garzik [EMAIL PROTECTED] wrote:
Finally, I don't know if I mentioned this earlier, but to be complete
and optimal, version strings should be a single variable 'version', such
that it can be passed directly to printk like
printk(version);
printk(%s\n, version);
Not quite as optimal but safer.
I disagree. Don't work around an escape bug in a version string, fix
it...
A % in a version string might be quite reasonable. You are asking to have
an accident by avoiding it. If you want to fight over 4 bytes, then add
Keith Owens wrote:
>
> On Sat, 19 May 2001 17:58:49 -0400,
> Jeff Garzik <[EMAIL PROTECTED]> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk
On Sat, 19 May 2001 17:58:49 -0400,
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>Finally, I don't know if I mentioned this earlier, but to be complete
>and optimal, version strings should be a single variable 'version', such
>that it can be passed directly to printk like
>
> printk(version);
Patch looks decent. Adding module descriptions was quite nice. One
flaw that is repeated multiple times is that you add
#ifdef MODULE
printk(version);
#endif
in an ISA driver's probe routine. This instead should always be the
first operation of init_module.
Also make
>From kufel!root Sat May 19 23:39:35 2001
Return-Path:
Received: from kufel.UUCP (uucp@localhost)
by green.mif.pg.gda.pl (8.9.3/8.9.3) with UUCP id XAA02226
for green.mif.pg.gda.pl!ankry; Sat, 19 May 2001 23:39:35 +0200
Received: (from root@localhost)
by kufel.dom
From kufel!root Sat May 19 23:39:35 2001
Return-Path: kufel!root
Received: from kufel.UUCP (uucp@localhost)
by green.mif.pg.gda.pl (8.9.3/8.9.3) with UUCP id XAA02226
for green.mif.pg.gda.pl!ankry; Sat, 19 May 2001 23:39:35 +0200
Received: (from root@localhost)
by
Patch looks decent. Adding module descriptions was quite nice. One
flaw that is repeated multiple times is that you add
#ifdef MODULE
printk(version);
#endif
in an ISA driver's probe routine. This instead should always be the
first operation of init_module.
Also make
On Sat, 19 May 2001 17:58:49 -0400,
Jeff Garzik [EMAIL PROTECTED] wrote:
Finally, I don't know if I mentioned this earlier, but to be complete
and optimal, version strings should be a single variable 'version', such
that it can be passed directly to printk like
printk(version);
Nit
Keith Owens wrote:
On Sat, 19 May 2001 17:58:49 -0400,
Jeff Garzik [EMAIL PROTECTED] wrote:
Finally, I don't know if I mentioned this earlier, but to be complete
and optimal, version strings should be a single variable 'version', such
that it can be passed directly to printk like
12 matches
Mail list logo
