Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

2019-06-14 Thread Rafael J. Wysocki
On Fri, Jun 14, 2019 at 12:45 PM Mika Westerberg wrote: > > On Thu, Jun 13, 2019 at 10:24:41PM +0200, Rafael J. Wysocki wrote: > > This patch may cause events to be missed if the GPE. I guess what you > > reall mean is > > something like the patch below. > > > > This should allow the kernel to

Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

2019-06-14 Thread Mika Westerberg
On Thu, Jun 13, 2019 at 10:24:41PM +0200, Rafael J. Wysocki wrote: > This patch may cause events to be missed if the GPE. I guess what you reall > mean is > something like the patch below. > > This should allow the kernel to see the events generated before the GPEs are > implicitly enabled, but

Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

2019-06-13 Thread Furquan Shaikh
On Thu, Jun 13, 2019 at 1:24 PM Rafael J. Wysocki wrote: > > On Thursday, May 16, 2019 9:36:16 PM CEST Furquan Shaikh wrote: > > This change clears GPE status for wake-up devices before enabling that > > GPE. This is required to ensure that stale GPE status does > > not result in pre-mature wake

Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

2019-06-13 Thread Rafael J. Wysocki
On Thursday, May 16, 2019 9:36:16 PM CEST Furquan Shaikh wrote: > This change clears GPE status for wake-up devices before enabling that > GPE. This is required to ensure that stale GPE status does > not result in pre-mature wake on enabling GPE for wake-up devices. > > Without this change, here

[PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

2019-05-16 Thread Furquan Shaikh
This change clears GPE status for wake-up devices before enabling that GPE. This is required to ensure that stale GPE status does not result in pre-mature wake on enabling GPE for wake-up devices. Without this change, here is the sequence of events that is causing suspend aborts on recent chrome