gt;; Len Brown ; ACPI Devel
> Maling List ; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) ; Linux Kernel Mailing List
> ; linux-tegra
> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
>
> On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki
> wrote:
> >
&g
gt;; Len Brown ; ACPI Devel
> Maling List ; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) ; Linux Kernel Mailing List
> ; linux-tegra
> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
>
> On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki
> wrote:
> >
&g
On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki wrote:
>
> On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter wrote:
> >
> >
> > On 11/11/2020 02:11, Nick Desaulniers wrote:
> > > The "fallthrough" pseudo-keyword was added as a portable way to denote
> > > intentional fallthrough. This code seemed to
On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter wrote:
>
>
> On 11/11/2020 02:11, Nick Desaulniers wrote:
> > The "fallthrough" pseudo-keyword was added as a portable way to denote
> > intentional fallthrough. This code seemed to be using a mix of
> > fallthrough comments that GCC recognizes, and some
On 11/11/2020 02:11, Nick Desaulniers wrote:
> The "fallthrough" pseudo-keyword was added as a portable way to denote
> intentional fallthrough. This code seemed to be using a mix of
> fallthrough comments that GCC recognizes, and some kind of lint marker.
> I'm guessing that linter hasn't been r
@vger.kernel.org
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
On Fri, Nov 13, 2020 at 1:45 PM Moore, Robert wrote:
>
> BTW, if you can make a pull request for the patch up on github, that would
> help.
https://github.com/acpica/acpica/pull/650
Great, thanks. I'll look at/merge the request
rom: Nick Desaulniers
Date: Fri, 13 Nov 2020 13:46:04 -0800
Subject: [PATCH] ACPICA: fix -Wfallthrough
GCC 7.1 gained -Wimplicit-fallthrough to warn on implicit fallthrough,
as well as __attribute__((__fallthrough__)) and comments to explicitly
denote that cases of fallthrough were intentional. C
Brown ;
linux-a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH] ACPICA: fix -Wfallthrough
-Original Message-
From: Moore, Robert
Sent: Friday, November 13, 2020 1:42 PM
To: Nick Desaulniers
Cc: Kaneda, Erik ; Wysocki, Rafael J
; Gustavo A . R
@vger.kernel.org
Subject: RE: [PATCH] ACPICA: fix -Wfallthrough
-Original Message-
From: Nick Desaulniers
Sent: Friday, November 13, 2020 1:33 PM
To: Moore, Robert
Cc: Kaneda, Erik ; Wysocki, Rafael J
; Gustavo A . R . Silva ;
clang-built-li...@googlegroups.com; Len Brown ;
linux-a
..@googlegroups.com; Len Brown ;
> linux-a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
>
> On Fri, Nov 13, 2020 at 1:27 PM Moore, Robert wrote:
> >
> >
> >
> > -Original Message-
> &g
@vger.kernel.org
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
On Fri, Nov 13, 2020 at 1:27 PM Moore, Robert wrote:
>
>
>
> -Original Message-
> From: ndesaulniers via sendgmr
> On Behalf Of Nick
> Desaulniers
> Sent: Tuesday, November 10, 2020 6:12 PM
> To: M
avo A . R . Silva
> Cc: clang-built-li...@googlegroups.com; Nick Desaulniers
> ; Len Brown ;
> linux-a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] ACPICA: fix -Wfallthrough
>
> The "fallthrough" pseudo-keyword was added as a po
...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
Subject: [PATCH] ACPICA: fix -Wfallthrough
The "fallthrough" pseudo-keyword was added as a portable way to denote
intentional fallthrough. This code seemed to be using a mix of fallthrough
comments that GCC recognizes, and
On Fri, Nov 13, 2020 at 1:01 PM Moore, Robert wrote:
>
> I can do it this way:
>
> In the global header actypes.h:
>
> #ifndef ACPI_FALLTHROUGH
> #define ACPI_FALLTHROUGH
> #endif
>
> In the gcc-specific header (acgcc.h):
>
> #define ACPI_FALLTHROUGH__attribute__((__fallthrough__))
>
> Thi
Re: [PATCH] ACPICA: fix -Wfallthrough
On Fri, 2020-11-13 at 09:14 +0100, Miguel Ojeda wrote:
> On Fri, Nov 13, 2020 at 1:09 AM Nick Desaulniers
> wrote:
> >
> > Thank you for the explicit diagnostics observed. Something fishy is
> > going on though, https://godbolt.org/z/G
On Fri, Nov 13, 2020 at 12:14 AM Miguel Ojeda
wrote:
>
> On Fri, Nov 13, 2020 at 1:09 AM Nick Desaulniers
> wrote:
> >
> > Thank you for the explicit diagnostics observed. Something fishy is
> > going on though, https://godbolt.org/z/Gbxbxa is how I expect MSVC to
> > handle include/linux/compil
On Fri, 2020-11-13 at 09:14 +0100, Miguel Ojeda wrote:
> On Fri, Nov 13, 2020 at 1:09 AM Nick Desaulniers
> wrote:
> >
> > Thank you for the explicit diagnostics observed. Something fishy is
> > going on though, https://godbolt.org/z/Gbxbxa is how I expect MSVC to
> > handle include/linux/compil
On Fri, Nov 13, 2020 at 1:09 AM Nick Desaulniers
wrote:
>
> Thank you for the explicit diagnostics observed. Something fishy is
> going on though, https://godbolt.org/z/Gbxbxa is how I expect MSVC to
> handle include/linux/compiler_attributes.h.
>
> The C preprocessor should make it such that MSV
On Thu, Nov 12, 2020 at 10:49 PM Moore, Robert wrote:
>
> 1>c:\acpica\source\components\utilities\utdelete.c(270): warning C4013:
> '__attribute__' undefined; assuming extern returning int
> 1>c:\acpica\source\components\utilities\utdelete.c(270): error C2065:
> '__fallthrough__': undeclared ide
..@googlegroups.com; Len Brown ;
> linux-a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
>
> On Thu, Nov 12, 2020 at 7:13 AM Moore, Robert wrote:
> >
> >
> >
> > -Original Message-
>
@vger.kernel.org
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
On Thu, Nov 12, 2020 at 7:13 AM Moore, Robert wrote:
>
>
>
> -Original Message-
> From: Nick Desaulniers
> Sent: Wednesday, November 11, 2020 10:48 AM
> To: Moore, Robert
> Cc: Kaneda, Erik ; Wysocki, Raf
On Thu, 2020-11-12 at 11:30 -0800, Nick Desaulniers wrote:
> On Thu, Nov 12, 2020 at 7:13 AM Moore, Robert wrote:
> > -Original Message-
> > From: Nick Desaulniers
> > On Wed, Nov 11, 2020 at 7:15 AM Moore, Robert
> > wrote:
> > > Yes, but: isn't the "fallthrough" keyword compiler-speci
..@googlegroups.com; Len Brown ;
> linux-a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
>
> On Wed, Nov 11, 2020 at 7:15 AM Moore, Robert wrote:
> >
> > Yes, but: isn't the "fallthrough"
@vger.kernel.org
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
On Wed, Nov 11, 2020 at 7:15 AM Moore, Robert wrote:
>
> Yes, but: isn't the "fallthrough" keyword compiler-specific? That is the
> problem for us.
It's not a keyword.
It's a preprocessor macro that expands
alf Of Nick Desaulniers
> Sent: Tuesday, November 10, 2020 6:12 PM
> To: Moore, Robert ; Kaneda, Erik
> ; Wysocki, Rafael J ;
> Gustavo A . R . Silva
> Cc: clang-built-li...@googlegroups.com; Nick Desaulniers
> ; Len Brown ;
> linux-a...@vger.kernel.org; de...@acpica.org;
Gustavo A . R . Silva
Cc: clang-built-li...@googlegroups.com; Nick Desaulniers
; Len Brown ;
linux-a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org
Subject: [PATCH] ACPICA: fix -Wfallthrough
The "fallthrough" pseudo-keyword was added as a portable way to denote
The "fallthrough" pseudo-keyword was added as a portable way to denote
intentional fallthrough. This code seemed to be using a mix of
fallthrough comments that GCC recognizes, and some kind of lint marker.
I'm guessing that linter hasn't been run in a while from the mixed use
of the marker vs comme
27 matches
Mail list logo
