Re: [PATCH] ALSA: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-05-22 Thread Takashi Iwai
At Thu, 22 May 2014 17:08:54 +0200, Benoit Taine wrote: > > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. > > A simplified version of the semantic patch that makes this change is as

[PATCH] ALSA: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-05-22 Thread Benoit Taine
We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i; declarer

[PATCH] ALSA: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-05-22 Thread Benoit Taine
We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // smpl @@ identifier i;

Re: [PATCH] ALSA: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-05-22 Thread Takashi Iwai
At Thu, 22 May 2014 17:08:54 +0200, Benoit Taine wrote: We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as