Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Sasha Levin
On 11/12/2012 10:23 AM, Russell King - ARM Linux wrote: > On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: >> Op 08-11-12 21:23, Sasha Levin schreef: >>> @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int >>> combiner_nr, unsigned int i >>> else >>>

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Sasha Levin
On 11/12/2012 10:12 AM, Maarten Lankhorst wrote: > Op 08-11-12 21:23, Sasha Levin schreef: >> Just use BUG_ON() instead of constructions such as: >> >> if (...) >> BUG() >> >> A simplified version of the semantic patch that makes this transformation >> is as follows:

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: > Op 08-11-12 21:23, Sasha Levin schreef: > > @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int > > combiner_nr, unsigned int i > > else > > max_nr = EXYNOS4_MAX_COMBINER_NR; > > > > -

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Maarten Lankhorst
Op 08-11-12 21:23, Sasha Levin schreef: > Just use BUG_ON() instead of constructions such as: > > if (...) > BUG() > > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression e; > @@ > -

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Maarten Lankhorst
Op 08-11-12 21:23, Sasha Levin schreef: Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e)

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int combiner_nr, unsigned int i else max_nr = EXYNOS4_MAX_COMBINER_NR; - if

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Sasha Levin
On 11/12/2012 10:12 AM, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows:

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Sasha Levin
On 11/12/2012 10:23 AM, Russell King - ARM Linux wrote: On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int combiner_nr, unsigned int i else

[PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ - if (e) BUG(); + BUG_ON(e); // Signed-off-by: Sasha Levin

[PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e) BUG(); + BUG_ON(e); // /smpl Signed-off-by: