Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-20 Thread Peter Ujfalusi
On 06/05/2020 11.43, Jason Yan wrote: > > > 在 2020/5/6 16:29, Russell King - ARM Linux admin 写道: >> On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: >>> Fix the following coccicheck warning: >>> >>> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return >>> "0" on

Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-06 Thread Jason Yan
在 2020/5/6 16:29, Russell King - ARM Linux admin 写道: On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: Fix the following coccicheck warning: arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 NAK. Look closer at what the code is doing,

Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-06 Thread Russell King - ARM Linux admin
On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return > "0" on line 161 NAK. Look closer at what the code is doing, thanks. This warning is basically incorrect. -- RMK's

[PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-06 Thread Jason Yan
Fix the following coccicheck warning: arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 Signed-off-by: Jason Yan --- arch/arm/mach-omap2/dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/dma.c