Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-10 Thread Joachim Eastwood
Hi Daniel, On 9 June 2015 at 19:37, Daniel Thompson wrote: > On 09/06/15 16:01, Russell King - ARM Linux wrote: >> >> On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: >>> >>> Does the following patch, which makes the arch_irqs_disabled() >>> implementation from asm-generic

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-10 Thread Maxime Coquelin
2015-06-09 19:37 GMT+02:00 Daniel Thompson : > On 09/06/15 16:01, Russell King - ARM Linux wrote: >> >> On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: >>> >>> Does the following patch, which makes the arch_irqs_disabled() >>> implementation from asm-generic available on arm, fix

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-10 Thread Maxime Coquelin
2015-06-09 19:37 GMT+02:00 Daniel Thompson daniel.thomp...@linaro.org: On 09/06/15 16:01, Russell King - ARM Linux wrote: On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: Does the following patch, which makes the arch_irqs_disabled() implementation from asm-generic available

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-10 Thread Joachim Eastwood
Hi Daniel, On 9 June 2015 at 19:37, Daniel Thompson daniel.thomp...@linaro.org wrote: On 09/06/15 16:01, Russell King - ARM Linux wrote: On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: Does the following patch, which makes the arch_irqs_disabled() implementation from

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Daniel Thompson
On 09/06/15 16:01, Russell King - ARM Linux wrote: On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: Does the following patch, which makes the arch_irqs_disabled() implementation from asm-generic available on arm, fix the build for you? Yes, this is exactly the kind of fix for

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Russell King - ARM Linux
On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: > Does the following patch, which makes the arch_irqs_disabled() > implementation from asm-generic available on arm, fix the build for you? Yes, this is exactly the kind of fix for this I'm looking for. Once everyone's happy with

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Maxime Coquelin
Hi Daniel, 2015-06-09 13:41 GMT+02:00 Daniel Thompson : > On 09/06/15 10:14, Maxime Coquelin wrote: >>> >>> The real solution is to provide a definition _in asm-generic_ for >>> arch_irqs_disabled(), rather than having almost every arch doing: >>> >>> static inline bool arch_irqs_disabled(void)

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Daniel Thompson
On 09/06/15 10:14, Maxime Coquelin wrote: The real solution is to provide a definition _in asm-generic_ for arch_irqs_disabled(), rather than having almost every arch doing: static inline bool arch_irqs_disabled(void) { return arch_irqs_disabled_flags(arch_local_save_flags()); } I'm

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Maxime Coquelin
2015-06-09 0:47 GMT+02:00 Russell King - ARM Linux : > On Tue, Jun 09, 2015 at 12:24:48AM +0200, Maxime Coquelin wrote: >> Commit cb1293e2f594 ("ARM: 8375/1: disable some options on ARMv7-M") causes >> build failure on ARMv7-M machines: >> >> CC arch/arm/kernel/asm-offsets.s >> In file

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Maxime Coquelin
2015-06-09 0:47 GMT+02:00 Russell King - ARM Linux li...@arm.linux.org.uk: On Tue, Jun 09, 2015 at 12:24:48AM +0200, Maxime Coquelin wrote: Commit cb1293e2f594 (ARM: 8375/1: disable some options on ARMv7-M) causes build failure on ARMv7-M machines: CC arch/arm/kernel/asm-offsets.s In

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Daniel Thompson
On 09/06/15 10:14, Maxime Coquelin wrote: The real solution is to provide a definition _in asm-generic_ for arch_irqs_disabled(), rather than having almost every arch doing: static inline bool arch_irqs_disabled(void) { return arch_irqs_disabled_flags(arch_local_save_flags()); } I'm

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Russell King - ARM Linux
On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: Does the following patch, which makes the arch_irqs_disabled() implementation from asm-generic available on arm, fix the build for you? Yes, this is exactly the kind of fix for this I'm looking for. Once everyone's happy with it,

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Maxime Coquelin
Hi Daniel, 2015-06-09 13:41 GMT+02:00 Daniel Thompson daniel.thomp...@linaro.org: On 09/06/15 10:14, Maxime Coquelin wrote: The real solution is to provide a definition _in asm-generic_ for arch_irqs_disabled(), rather than having almost every arch doing: static inline bool

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-09 Thread Daniel Thompson
On 09/06/15 16:01, Russell King - ARM Linux wrote: On Tue, Jun 09, 2015 at 12:41:50PM +0100, Daniel Thompson wrote: Does the following patch, which makes the arch_irqs_disabled() implementation from asm-generic available on arm, fix the build for you? Yes, this is exactly the kind of fix for

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-08 Thread Russell King - ARM Linux
On Tue, Jun 09, 2015 at 12:24:48AM +0200, Maxime Coquelin wrote: > Commit cb1293e2f594 ("ARM: 8375/1: disable some options on ARMv7-M") causes > build failure on ARMv7-M machines: > > CC arch/arm/kernel/asm-offsets.s > In file included from include/linux/sem.h:5:0, > from

[PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-08 Thread Maxime Coquelin
Commit cb1293e2f594 ("ARM: 8375/1: disable some options on ARMv7-M") causes build failure on ARMv7-M machines: CC arch/arm/kernel/asm-offsets.s In file included from include/linux/sem.h:5:0, from include/linux/sched.h:35, from

[PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-08 Thread Maxime Coquelin
Commit cb1293e2f594 (ARM: 8375/1: disable some options on ARMv7-M) causes build failure on ARMv7-M machines: CC arch/arm/kernel/asm-offsets.s In file included from include/linux/sem.h:5:0, from include/linux/sched.h:35, from

Re: [PATCH] ARM: Re-enable TRACE_IRQFLAGS_SUPPORT on ARMv7-M

2015-06-08 Thread Russell King - ARM Linux
On Tue, Jun 09, 2015 at 12:24:48AM +0200, Maxime Coquelin wrote: Commit cb1293e2f594 (ARM: 8375/1: disable some options on ARMv7-M) causes build failure on ARMv7-M machines: CC arch/arm/kernel/asm-offsets.s In file included from include/linux/sem.h:5:0, from