Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-20 Thread Arnd Bergmann
On Friday 19 December 2014 15:15:09 Stefan Hengelein wrote: > From what i can see, the block was already dead when it was introduced. > d2193ce2 changed the "if ARCH_S3C64XX" into the Kconfig file itself, > before it was around the source statement in arch/arm/Kconfig > > if there are really just

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-19 Thread Stefan Hengelein
>From what i can see, the block was already dead when it was introduced. d2193ce2 changed the "if ARCH_S3C64XX" into the Kconfig file itself, before it was around the source statement in arch/arm/Kconfig if there are really just downstream users that explicitly have to add a statement to select S3

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-18 Thread Heiko Stübner
Hi Stefan, Am Donnerstag, 18. Dezember 2014, 14:43:01 schrieb Stefan Hengelein: > So you actually tested the code I removed in the patch? can you > provide a configuration that compiles that piece of code? Yep, one of my boards (Asus eeeReader DR-900) was actually able to transmit stuff via the l

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-18 Thread Stefan Hengelein
So you actually tested the code I removed in the patch? can you provide a configuration that compiles that piece of code? 2014-12-17 17:16 GMT+01:00 Heiko Stübner : > Am Mittwoch, 17. Dezember 2014, 16:52:40 schrieb Arnd Bergmann: >> On Wednesday 17 December 2014 16:40:37 Stefan Hengelein wrote: >

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-17 Thread Heiko Stübner
Am Mittwoch, 17. Dezember 2014, 16:52:40 schrieb Arnd Bergmann: > On Wednesday 17 December 2014 16:40:37 Stefan Hengelein wrote: > > The corresponding CPP-block can never be selected since there are > > conflicting Kconfig constraints: > > - CONFIG_S3C24XX_DMAC has a dependency on ARCH_S3C24XX > >

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-17 Thread Arnd Bergmann
On Wednesday 17 December 2014 16:40:37 Stefan Hengelein wrote: > The corresponding CPP-block can never be selected since there are > conflicting Kconfig constraints: > - CONFIG_S3C24XX_DMAC has a dependency on ARCH_S3C24XX > - The surrounding CPP-block needs CONFIG_S3C64XX_DEV_SPI0 to be defined. >

[PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-17 Thread Stefan Hengelein
The corresponding CPP-block can never be selected since there are conflicting Kconfig constraints: - CONFIG_S3C24XX_DMAC has a dependency on ARCH_S3C24XX - The surrounding CPP-block needs CONFIG_S3C64XX_DEV_SPI0 to be defined. - CONFIG_S3C64XX_DEV_SPI0 is only selected by MACH_WLF_CRAGG_6410 -