Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-20 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 10:42:01PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 06:19:13PM +0100, Russell King - ARM Linux admin > wrote: > > whether you can get the link to come up at all. You might need to see > > whether wiggling the RJ45 helps (I've had that sort of

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-20 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 08:39:34PM +0200, Andrew Lunn wrote: > > > Well, the _correct_ driver needs to be used for the PHY specific > > > features to be properly controlled. Using the generic driver > > > in this situation will not be guaranteed to work. > > I fully agree about the PHY driver.

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-18 Thread tinywrkb
On Tue, Sep 17, 2019 at 11:43:47PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 11:30:13PM +0100, Russell King - ARM Linux admin > wrote: > > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > > Here's the output of # mii-tool -v -v eth0 > > > > > > *

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 11:30:13PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > Here's the output of # mii-tool -v -v eth0 > > > > * linux-test-5.1rc1-a2703de70942-without_bad_commit > > > > Using SIOCGMIIPHY=0x8947 > > eth0:

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > Here's the output of # mii-tool -v -v eth0 > > * linux-test-5.1rc1-a2703de70942-without_bad_commit > > Using SIOCGMIIPHY=0x8947 > eth0: negotiated 100baseTx-FD flow-control, link ok > registers for MII PHY 0: > 3100 796d 004d

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 06:19:13PM +0100, Russell King - ARM Linux admin wrote: > whether you can get the link to come up at all. You might need to see > whether wiggling the RJ45 helps (I've had that sort of thing with some > cables.) > > You might also need "ethtool -s eth0 advertise ffcf"

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Andrew Lunn
> > Well, the _correct_ driver needs to be used for the PHY specific > > features to be properly controlled. Using the generic driver > > in this situation will not be guaranteed to work. I fully agree about the PHY driver. I'm expect this device is violating c22 when it modifies the

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 06:37:28PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote: > > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > > index b3893347804d..85cf4a4a5e81 100644 > > > --- a/drivers/net/phy/at803x.c >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > index b3893347804d..85cf4a4a5e81 100644 > > --- a/drivers/net/phy/at803x.c > > +++ b/drivers/net/phy/at803x.c > > Hi Russell > > This won't work. In the kernel

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Andrew Lunn
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index b3893347804d..85cf4a4a5e81 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c Hi Russell This won't work. In the kernel logs, you see kernel: Generic PHY 2188000.ethernet-1:00: attached PHY driver

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 06:04:19PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 07:34:27PM +0300, tinywrkb wrote: > > The patch didn't fix the issue. > > > > # ethtool eth0 > > > > Settings for eth0: > > Supported ports: [ TP MII ] > > Supported link modes:

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 07:34:27PM +0300, tinywrkb wrote: > The patch didn't fix the issue. > > # ethtool eth0 > > Settings for eth0: > Supported ports: [ TP MII ] > Supported link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread tinywrkb
On Tue, Sep 17, 2019 at 04:30:27PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 04:17:07PM +0100, Russell King - ARM Linux admin > wrote: > > On Tue, Sep 17, 2019 at 02:39:43PM +0100, Russell King - ARM Linux admin > > wrote: > > > On Tue, Sep 17, 2019 at 04:32:53PM

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 04:17:07PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 02:39:43PM +0100, Russell King - ARM Linux admin > wrote: > > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > > On Tue, Sep 17, 2019 at 02:54:34PM +0200, Andrew Lunn wrote: > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 02:39:43PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > On Tue, Sep 17, 2019 at 02:54:34PM +0200, Andrew Lunn wrote: > > > On Tue, Sep 17, 2019 at 03:41:01PM +0300, tinywrkb wrote: > > > > On Sun, Sep 15, 2019

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > On Tue, Sep 17, 2019 at 02:54:34PM +0200, Andrew Lunn wrote: > > On Tue, Sep 17, 2019 at 03:41:01PM +0300, tinywrkb wrote: > > > On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > > > > Tinywrkb confirmed to me in private

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread tinywrkb
On Tue, Sep 17, 2019 at 02:54:34PM +0200, Andrew Lunn wrote: > On Tue, Sep 17, 2019 at 03:41:01PM +0300, tinywrkb wrote: > > On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > > > Tinywrkb confirmed to me in private communication that revert of > > > > 5502b218e001 fixes Ethernet for

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Andrew Lunn
On Tue, Sep 17, 2019 at 03:41:01PM +0300, tinywrkb wrote: > On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > > Tinywrkb confirmed to me in private communication that revert of > > > 5502b218e001 fixes Ethernet for him on effected system. > > > > > > He also referred me to an old

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread tinywrkb
On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > Tinywrkb confirmed to me in private communication that revert of > > 5502b218e001 fixes Ethernet for him on effected system. > > > > He also referred me to an old Cubox-i spec that lists 10/100 Ethernet > > only for i.MX6

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 04:42:52PM +0200, Andrew Lunn wrote: > > > OF: fdt: Machine model: SolidRun HummingBoard Solo/DualLite > > > ... > > > # ethtool eth0 > > > Settings for eth0: > > > Supported ports: [ TP MII ] > > > Supported link modes: 10baseT/Half 10baseT/Full > > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Andrew Lunn
> > OF: fdt: Machine model: SolidRun HummingBoard Solo/DualLite > > ... > > # ethtool eth0 > > Settings for eth0: > > Supported ports: [ TP MII ] > > Supported link modes: 10baseT/Half 10baseT/Full > > 100baseT/Half 100baseT/Full > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 03:06:39PM +0100, Russell King - ARM Linux admin wrote: > On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > > Tinywrkb confirmed to me in private communication that revert of > > > 5502b218e001 fixes Ethernet for him on effected system. > > > > > > He also

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > Tinywrkb confirmed to me in private communication that revert of > > 5502b218e001 fixes Ethernet for him on effected system. > > > > He also referred me to an old Cubox-i spec that lists 10/100 Ethernet > > only for i.MX6

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Andrew Lunn
> Tinywrkb confirmed to me in private communication that revert of > 5502b218e001 fixes Ethernet for him on effected system. > > He also referred me to an old Cubox-i spec that lists 10/100 Ethernet > only for i.MX6 Solo/DualLite variants of Cubox-i. It turns out that > there was a plan to use a

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 09:30:00AM +0300, Baruch Siach wrote: > Hi Andrew, > > On Tue, Sep 10 2019, Andrew Lunn wrote: > > On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > >> Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > >> Atheros AR8035 PHY on the MicroSoM

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Baruch Siach
Hi Andrew, On Tue, Sep 10 2019, Andrew Lunn wrote: > On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: >> Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the >> Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. >> >> Since commit 5502b218e001 ("net:

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Andrew Lunn
On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. > > Since commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Russell King - ARM Linux admin
On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the That statement is false, sorry. All boards support 1G. > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. > > Since commit 5502b218e001 ("net:

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Baruch Siach
Hi tinywrkb, On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. According to the hardware designer, Rabeeh Khoury, there is not such limitation

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Fabio Estevam
Adding Jon and Baruch On Tue, Sep 10, 2019 at 12:55 PM tinywrkb wrote: > > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. > > Since commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in >

[PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread tinywrkb
Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. Since commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") ethernet is broken on Cubox-i Solo/DualLite devices. This adds