Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-07 Thread One Thousand Gnomes
On Thu, 6 Mar 2014 18:23:39 +0100 Andrew Lunn wrote: > > Can't we fix this so the probe order doesn't affect the name? > > > > Is that sane? > > You are not supposed to trust the device name, since probing can > happen in parallel, on different buses. udev should have rules to name > the interf

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-07 Thread Jason Cooper
On Fri, Mar 07, 2014 at 10:53:42AM +0100, Gregory CLEMENT wrote: > On 06/03/2014 20:17, Ezequiel Garcia wrote: > > On Mar 06, Andrew Lunn wrote: > >>> Can't we fix this so the probe order doesn't affect the name? > >>> > >>> Is that sane? > >> > >> You are not supposed to trust the device name, sin

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-07 Thread Gregory CLEMENT
On 06/03/2014 20:17, Ezequiel Garcia wrote: > On Mar 06, Andrew Lunn wrote: >>> Can't we fix this so the probe order doesn't affect the name? >>> >>> Is that sane? >> >> You are not supposed to trust the device name, since probing can >> happen in parallel, on different buses. udev should have rule

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Ezequiel Garcia
On Mar 06, Andrew Lunn wrote: > > Can't we fix this so the probe order doesn't affect the name? > > > > Is that sane? > > You are not supposed to trust the device name, since probing can > happen in parallel, on different buses. udev should have rules to name > the interfaces based on the MAC add

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Andrew Lunn
> Can't we fix this so the probe order doesn't affect the name? > > Is that sane? You are not supposed to trust the device name, since probing can happen in parallel, on different buses. udev should have rules to name the interfaces based on the MAC address. On my Debian system i have: /etc/udev

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Ezequiel Garcia
On Mar 06, Gregory CLEMENT wrote: > On 06/03/2014 15:51, Gregory CLEMENT wrote: > > the dsi file. > > > > I will have a look on the ethernet driver. > > Well the naming is done in __dev_alloc_name() and it depends on > the probe order. > Can't we fix this so the probe order doesn't affect the n

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Gregory CLEMENT
On 06/03/2014 15:51, Gregory CLEMENT wrote: > On 06/03/2014 15:46, Andrew Lunn wrote: >> I think you can use aliases to get the order correct, independent of >> how you list them in DT. That should be a lot safer than assuming >> things are instantiated from top to bottom. > > I

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Gregory CLEMENT
On 06/03/2014 15:46, Andrew Lunn wrote: > I think you can use aliases to get the order correct, independent of > how you list them in DT. That should be a lot safer than assuming > things are instantiated from top to bottom. It sounds interesting, how would you do this? >>> >>

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Andrew Lunn
> >>> I think you can use aliases to get the order correct, independent of > >>> how you list them in DT. That should be a lot safer than assuming > >>> things are instantiated from top to bottom. > >> > >> It sounds interesting, how would you do this? > > > > As there already is in armada-370-xp.

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Gregory CLEMENT
On 06/03/2014 15:21, Andrew Lunn wrote: >>> Hi Gregory >>> >>> I guess checkpatch.pl is probably complaining about missing vendor >>> prefix? >>> >> >> yes and also about m25p128 itself because it was not explicitly written >> in Documentation/devicetree/bindings/. Actually it was written to "see t

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Andrew Lunn
> > Hi Gregory > > > > I guess checkpatch.pl is probably complaining about missing vendor > > prefix? > > > > yes and also about m25p128 itself because it was not explicitly written > in Documentation/devicetree/bindings/. Actually it was written to "see the > "m25p_ids" table in drivers/mtd/dev

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Gregory CLEMENT
Hi Andrew, On 06/03/2014 14:14, Andrew Lunn wrote: > On Thu, Mar 06, 2014 at 01:11:08PM +0100, Gregory CLEMENT wrote: >> The Armada 385 RD board is the reference design board from Marvell >> for the Armada 385 SoC. This commit adds a Device Tree description for >> this board, which enables the fol

Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Andrew Lunn
On Thu, Mar 06, 2014 at 01:11:08PM +0100, Gregory CLEMENT wrote: > The Armada 385 RD board is the reference design board from Marvell > for the Armada 385 SoC. This commit adds a Device Tree description for > this board, which enables the following features: > > * Network interfaces > * I2C bus

[PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board

2014-03-06 Thread Gregory CLEMENT
The Armada 385 RD board is the reference design board from Marvell for the Armada 385 SoC. This commit adds a Device Tree description for this board, which enables the following features: * Network interfaces * I2C bus * Serial port * SPI bus, with a SPI flash * PCIe interface Signed-off-by: