Re: [PATCH] ARM : unwinder : Prevent data abort due to stack overflow in unwind_exec_insn Signed-off-by: Anurag Aggarwal

2013-11-28 Thread Anurag Aggarwal
Hi Dave, I aplogize for wrong formatting of multiline comments. > I really think this shouldn't be separated out in this way, because it > means the decoder has to be implemented twice, and moving the checks far > away from the code that the checks need to match. I believe that you are right in

Re: [PATCH] ARM : unwinder : Prevent data abort due to stack overflow in unwind_exec_insn Signed-off-by: Anurag Aggarwal

2013-11-28 Thread Dave Martin
On Thu, Nov 28, 2013 at 03:57:19PM +0530, Anurag Aggarwal wrote: > While executing some unwind instructions stack overflow can cause a data abort > when area beyond stack is not mapped to physical memory. > > To prevent the data abort check whether it is possible to execute > these instructions

[PATCH] ARM : unwinder : Prevent data abort due to stack overflow in unwind_exec_insn Signed-off-by: Anurag Aggarwal

2013-11-28 Thread Anurag Aggarwal
While executing some unwind instructions stack overflow can cause a data abort when area beyond stack is not mapped to physical memory. To prevent the data abort check whether it is possible to execute these instructions before unwinding the stack --- arch/arm/kernel/unwind.c | 59

[PATCH] ARM : unwinder : Prevent data abort due to stack overflow in unwind_exec_insn Signed-off-by: Anurag Aggarwal a.anu...@samsung.com

2013-11-28 Thread Anurag Aggarwal
While executing some unwind instructions stack overflow can cause a data abort when area beyond stack is not mapped to physical memory. To prevent the data abort check whether it is possible to execute these instructions before unwinding the stack --- arch/arm/kernel/unwind.c | 59

Re: [PATCH] ARM : unwinder : Prevent data abort due to stack overflow in unwind_exec_insn Signed-off-by: Anurag Aggarwal a.anu...@samsung.com

2013-11-28 Thread Dave Martin
On Thu, Nov 28, 2013 at 03:57:19PM +0530, Anurag Aggarwal wrote: While executing some unwind instructions stack overflow can cause a data abort when area beyond stack is not mapped to physical memory. To prevent the data abort check whether it is possible to execute these instructions before

Re: [PATCH] ARM : unwinder : Prevent data abort due to stack overflow in unwind_exec_insn Signed-off-by: Anurag Aggarwal a.anu...@samsung.com

2013-11-28 Thread Anurag Aggarwal
Hi Dave, I aplogize for wrong formatting of multiline comments. I really think this shouldn't be separated out in this way, because it means the decoder has to be implemented twice, and moving the checks far away from the code that the checks need to match. I believe that you are right in