RE: [PATCH] ASoC: Intel: sof_rt5682: Add rt1015p speaker amp support

2021-03-16 Thread Lu, Brent
> > could we not handle this quirk inside one of the two dai_link or codec_conf > functions above? > The machine driver does not care about this RT1015P_SHARE_EN_SPK quirk, > it's only used in those two functions so should be set in this scope. > There's no need to make it visible to the machine

Re: [PATCH] ASoC: Intel: sof_rt5682: Add rt1015p speaker amp support

2021-03-15 Thread Pierre-Louis Bossart
I am not a big fan of the code partition you've selected. +void sof_rt1015p_set_share_en_spk(void) +{ + /* Two amps share one en pin so there is only one device in acpi +* table +*/ + rt1015p_quirk |= RT1015P_SHARE_EN_SPK; +} This is a function now used in the

RE: [PATCH] ASoC: Intel: sof_rt5682: Add rt1015p speaker amp support

2021-03-13 Thread Lu, Brent
> > This patch adds jsl_rt5682_rt1015p which supports the > RT5682 headset codec and RT1015P speaker amplifier combination on > JasperLake platform. > > Signed-off-by: Brent Lu > --- > sound/soc/codecs/rt1015p.c| 10 ++ > sound/soc/intel/boards/Kconfig| 1 +

[PATCH] ASoC: Intel: sof_rt5682: Add rt1015p speaker amp support

2021-03-13 Thread Brent Lu
This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset codec and RT1015P speaker amplifier combination on JasperLake platform. Signed-off-by: Brent Lu --- sound/soc/codecs/rt1015p.c| 10 ++ sound/soc/intel/boards/Kconfig| 1 +