Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-12-04 Thread Mark Brown
On Mon, Dec 04, 2017 at 08:46:24PM +0530, Vijendar Mukunda wrote: > added additional error checks in acp dma driver > v2: printed error codes for acp init & acp deinit > failure cases. Don't include noise like inter-version changelogs in commit messages, add them after the --- if they're

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-12-04 Thread Mark Brown
On Mon, Dec 04, 2017 at 08:46:24PM +0530, Vijendar Mukunda wrote: > added additional error checks in acp dma driver > v2: printed error codes for acp init & acp deinit > failure cases. Don't include noise like inter-version changelogs in commit messages, add them after the --- if they're

[PATCH] ASoC: amd: added error checks in dma driver

2017-12-04 Thread Vijendar Mukunda
added additional error checks in acp dma driver v2: printed error codes for acp init & acp deinit failure cases. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-pcm-dma.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-)

[PATCH] ASoC: amd: added error checks in dma driver

2017-12-04 Thread Vijendar Mukunda
added additional error checks in acp dma driver v2: printed error codes for acp init & acp deinit failure cases. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-pcm-dma.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-29 Thread Mukunda,Vijendar
On Tuesday 28 November 2017 05:22 PM, Mark Brown wrote: On Tue, Nov 28, 2017 at 10:13:44AM +0530, Vijendar Mukunda wrote: - acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); + status = acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); + if (status)

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-29 Thread Mukunda,Vijendar
On Tuesday 28 November 2017 05:22 PM, Mark Brown wrote: On Tue, Nov 28, 2017 at 10:13:44AM +0530, Vijendar Mukunda wrote: - acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); + status = acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); + if (status)

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 10:13:44AM +0530, Vijendar Mukunda wrote: > - acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); > + status = acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); > + if (status) { > + dev_err(>dev, "ACP Init failed\n"); > +

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 10:13:44AM +0530, Vijendar Mukunda wrote: > - acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); > + status = acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); > + if (status) { > + dev_err(>dev, "ACP Init failed\n"); > +

[PATCH] ASoC: amd: added error checks in dma driver

2017-11-27 Thread Vijendar Mukunda
added additional error checks in acp dma driver Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-pcm-dma.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c

[PATCH] ASoC: amd: added error checks in dma driver

2017-11-27 Thread Vijendar Mukunda
added additional error checks in acp dma driver Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-pcm-dma.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-24 Thread Mukunda,Vijendar
On Friday 24 November 2017 01:41 PM, Guenter Roeck wrote: On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar wrote: On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: On Thu, Nov 23, 2017 at

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-24 Thread Mukunda,Vijendar
On Friday 24 November 2017 01:41 PM, Guenter Roeck wrote: On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar wrote: On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-24 Thread Guenter Roeck
On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar wrote: > > > > On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: >> >> On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: >>> >>> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda >>>

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-24 Thread Guenter Roeck
On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar wrote: > > > > On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: >> >> On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: >>> >>> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda >>> wrote: added error checks in acp

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Mukunda,Vijendar
On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda wrote: added error checks in acp dma driver Signed-off-by: Vijendar Mukunda

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Mukunda,Vijendar
On Thursday 23 November 2017 10:59 PM, Mark Brown wrote: On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda wrote: added error checks in acp dma driver Signed-off-by: Vijendar Mukunda Signed-off-by: Akshu Agrawal

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Mark Brown
On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: > On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda > wrote: > > added error checks in acp dma driver > > Signed-off-by: Vijendar Mukunda > > Signed-off-by: Akshu Agrawal

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Mark Brown
On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote: > On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda > wrote: > > added error checks in acp dma driver > > Signed-off-by: Vijendar Mukunda > > Signed-off-by: Akshu Agrawal > > Signed-off-by: Guenter Roeck > This is inappropriate.

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Guenter Roeck
On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda wrote: > added error checks in acp dma driver > > Signed-off-by: Vijendar Mukunda > Signed-off-by: Akshu Agrawal > Signed-off-by: Guenter Roeck

Re: [PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Guenter Roeck
On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda wrote: > added error checks in acp dma driver > > Signed-off-by: Vijendar Mukunda > Signed-off-by: Akshu Agrawal > Signed-off-by: Guenter Roeck This is inappropriate. Guenter > --- > sound/soc/amd/acp-pcm-dma.c | 45 >

[PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Vijendar Mukunda
added error checks in acp dma driver Signed-off-by: Vijendar Mukunda Signed-off-by: Akshu Agrawal Signed-off-by: Guenter Roeck --- sound/soc/amd/acp-pcm-dma.c | 45 - 1 file

[PATCH] ASoC: amd: added error checks in dma driver

2017-11-23 Thread Vijendar Mukunda
added error checks in acp dma driver Signed-off-by: Vijendar Mukunda Signed-off-by: Akshu Agrawal Signed-off-by: Guenter Roeck --- sound/soc/amd/acp-pcm-dma.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git