Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-27 Thread Maciej S. Szmigiero
W dniu 26.05.2015 16:09, Takashi Iwai pisze: > At Tue, 26 May 2015 16:03:17 +0200, > Maciej S. Szmigiero wrote: >> >> Hello Takashi, >> >> W dniu 26.05.2015 07:29, Takashi Iwai pisze: >>> At Sat, 23 May 2015 18:32:29 +0200, >>> Maciej S. Szmigiero wrote: snd_soc_pcm_stream.formats is a bi

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-26 Thread Takashi Iwai
At Tue, 26 May 2015 16:03:17 +0200, Maciej S. Szmigiero wrote: > > Hello Takashi, > > W dniu 26.05.2015 07:29, Takashi Iwai pisze: > > At Sat, 23 May 2015 18:32:29 +0200, > > Maciej S. Szmigiero wrote: > >> > >> snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, > >> not of SNDRV_PCM_

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-26 Thread Maciej S. Szmigiero
Hello Takashi, W dniu 26.05.2015 07:29, Takashi Iwai pisze: > At Sat, 23 May 2015 18:32:29 +0200, > Maciej S. Szmigiero wrote: >> >> snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, >> not of SNDRV_PCM_FORMAT_* (which are sequential integers), >> however some of ASoC CODEC drivers us

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-26 Thread Mark Brown
On Tue, May 26, 2015 at 07:29:57AM +0200, Takashi Iwai wrote: > Maciej S. Szmigiero wrote: > > Found out by sparse on 0-day kernel tester. > Wow, that made me wonder how these drivers could actually work. AFAICT the bits were being set by being ored in from the sequential values. > BTW, how did

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-25 Thread Takashi Iwai
At Sat, 23 May 2015 18:32:29 +0200, Maciej S. Szmigiero wrote: > > snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, > not of SNDRV_PCM_FORMAT_* (which are sequential integers), > however some of ASoC CODEC drivers use these values instead. > > Found out by sparse on 0-day kernel tes

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-25 Thread Mark Brown
On Sat, May 23, 2015 at 06:32:29PM +0200, Maciej S. Szmigiero wrote: > snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, > not of SNDRV_PCM_FORMAT_* (which are sequential integers), > however some of ASoC CODEC drivers use these values instead. Applied, htanks. signature.asc Descrip

Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-25 Thread Charles Keepax
On Sat, May 23, 2015 at 06:32:29PM +0200, Maciej S. Szmigiero wrote: > snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, > not of SNDRV_PCM_FORMAT_* (which are sequential integers), > however some of ASoC CODEC drivers use these values instead. > > Found out by sparse on 0-day kernel

[PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask

2015-05-23 Thread Maciej S. Szmigiero
snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*, not of SNDRV_PCM_FORMAT_* (which are sequential integers), however some of ASoC CODEC drivers use these values instead. Found out by sparse on 0-day kernel tester. Signed-off-by: Maciej Szmigiero diff --git a/sound/soc/codecs/88pm86