Re: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe

2021-03-18 Thread Shengjiu Wang
Hi Mark On Tue, Mar 16, 2021 at 9:51 PM Mark Brown wrote: > > On Tue, Mar 16, 2021 at 01:42:40PM +, Viorel Suman wrote: > > > To me it makes sense to manage the clocks and reset from the same place. > > Currently we have the clocks management moved completely into runtime PM > >

Re: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe

2021-03-16 Thread Mark Brown
On Tue, Mar 16, 2021 at 01:42:40PM +, Viorel Suman wrote: > To me it makes sense to manage the clocks and reset from the same place. > Currently we have the clocks management moved completely into runtime PM > fsl_sai_runtime_resume and fsl_sai_runtime_suspend callbacks. Usually the pattern

RE: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe

2021-03-16 Thread Viorel Suman
> On Tue, Mar 16, 2021 at 05:27:06PM +0800, Shengjiu Wang wrote: > > From: Viorel Suman > > > > SAI software reset is done in runtime resume, there is no need to do > > it in fsl_sai_dai_probe. > > People can disable runtime PM in their configurations - do you not still need > a > reset on

Re: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe

2021-03-16 Thread Shengjiu Wang
On Tue, Mar 16, 2021 at 9:01 PM Mark Brown wrote: > > On Tue, Mar 16, 2021 at 05:27:06PM +0800, Shengjiu Wang wrote: > > From: Viorel Suman > > > > SAI software reset is done in runtime resume, > > there is no need to do it in fsl_sai_dai_probe. > > People can disable runtime PM in their

Re: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe

2021-03-16 Thread Mark Brown
On Tue, Mar 16, 2021 at 05:27:06PM +0800, Shengjiu Wang wrote: > From: Viorel Suman > > SAI software reset is done in runtime resume, > there is no need to do it in fsl_sai_dai_probe. People can disable runtime PM in their configurations - do you not still need a reset on probe in case there's

[PATCH] ASoC: fsl_sai: remove reset code from dai_probe

2021-03-16 Thread Shengjiu Wang
From: Viorel Suman SAI software reset is done in runtime resume, there is no need to do it in fsl_sai_dai_probe. Signed-off-by: Viorel Suman Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_sai.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/sound/soc/fsl/fsl_sai.c