Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-28 Thread Timur Tabi
Maciej S. Szmigiero wrote: If there isn't going to be new platforms added with old bindings then this won't be needed - I'll remove it. I would love it if someone would port those original device trees to the new binding, so that we can get rid of the old one. But we should definitely not a

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-28 Thread Maciej S. Szmigiero
W dniu 28.06.2015 06:27, Timur Tabi pisze: > Maciej S. Szmigiero wrote: >> +if (newbinding && fsl_ssi_is_ac97(ssi_private)) { > > Is the "newbinding" necessary? I thought only the original PowerPC device > trees were the only one that have the old binding, and they never supported > AC97.

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Timur Tabi
Maciej S. Szmigiero wrote: + if (newbinding && fsl_ssi_is_ac97(ssi_private)) { Is the "newbinding" necessary? I thought only the original PowerPC device trees were the only one that have the old binding, and they never supported AC97. -- To unsubscribe from this list: send the line "u

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Maciej S. Szmigiero
Hello Fabio, W dniu 28.06.2015 01:06, Fabio Estevam pisze: > Hi Maciej, > > On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero > wrote: >> Currently the AC'97 mode in fsl_ssi driver isn't functional. > > Thanks for the fix. I look forward to test it on my udoo board. Thanks. >> This patch i

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Fabio Estevam
On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero wrote: > + > + ret = clk_prepare_enable(fsl_ac97_data->clk); > + if (ret) { > + pr_err("ac97 read clk_prepare_enable failed: %d\n", > + ret); > + return -1; 'return ret' would be be

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Fabio Estevam
Hi Maciej, On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero wrote: > Currently the AC'97 mode in fsl_ssi driver isn't functional. Thanks for the fix. I look forward to test it on my udoo board. > This patch implements the following changes to make it work > properly: > * IPG clock have to b

[PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Maciej S. Szmigiero
Currently the AC'97 mode in fsl_ssi driver isn't functional. This patch implements the following changes to make it work properly: * IPG clock have to be enabled during AC'97 CODEC register access, * AC'97 DAI driver struct need the same probe method as I2S one to setup DMA params, * AC'97 bus can