RE: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path

2021-04-02 Thread Steve Lee
m; > srinivas.kandaga...@linaro.org; k...@kernel.org; dmur...@ti.com; > jack...@realtek.com; nuno...@analog.com; linux-kernel@vger.kernel.org; > alsa-de...@alsa-project.org; ryan.lee.ma...@gmail.com; > steves.lee.ma...@gmail.com > Subject: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add c

Re: [PATCH] ASoC: max98390: Add controls for tx path

2021-04-02 Thread Mark Brown
On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote: > + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, > + 0, 255, 0), I'm not clear what this is (especially given the source selection below) but it looks like it should be a mute control? > + SOC_SINGLE("Tx Hi

[PATCH] ASoC: max98390: Add controls for tx path

2021-04-01 Thread Steve Lee
Add controls for tx source. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index bb736c44e68a..163093959da8 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/code