Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Mark Brown
On Sat, May 30, 2020 at 01:26:20AM +0800, Tzung-Bi Shih wrote: > On Fri, May 29, 2020 at 9:05 PM Mark Brown wrote: > > I thought that was normal for DMICs - is this selecting between left and > > right or something? > Not sure what is the common name but use the same context here. > MT6358

Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Tzung-Bi Shih
On Fri, May 29, 2020 at 9:05 PM Mark Brown wrote: > > On Fri, May 29, 2020 at 07:22:43PM +0800, Tzung-Bi Shih wrote: > > On Fri, May 29, 2020 at 7:09 PM Mark Brown wrote: > > > > What is DMIC one wire mode? This doesn't sound like something I'd > > > expect to vary at runtime. > > > It means: 1

Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Mark Brown
On Fri, May 29, 2020 at 07:22:43PM +0800, Tzung-Bi Shih wrote: > On Fri, May 29, 2020 at 7:09 PM Mark Brown wrote: > > What is DMIC one wire mode? This doesn't sound like something I'd > > expect to vary at runtime. > It means: 1 PDM data wire carries 2 channel data (rising edge for left > and

Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Tzung-Bi Shih
On Fri, May 29, 2020 at 7:09 PM Mark Brown wrote: > > On Fri, May 29, 2020 at 07:04:53PM +0800, Jiaxin Yu wrote: > > Supports DMIC one-wire mode. Adds a mixer control to enable and disable. > > What is DMIC one wire mode? This doesn't sound like something I'd > expect to vary at runtime. It

Re: [PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Mark Brown
On Fri, May 29, 2020 at 07:04:53PM +0800, Jiaxin Yu wrote: > Supports DMIC one-wire mode. Adds a mixer control to enable and disable. What is DMIC one wire mode? This doesn't sound like something I'd expect to vary at runtime. signature.asc Description: PGP signature

[PATCH] ASoC: mediatek: mt6358: support DMIC one-wire mode

2020-05-29 Thread Jiaxin Yu
Supports DMIC one-wire mode. Adds a mixer control to enable and disable. Signed-off-by: Jiaxin Yu Reviewed-by: Tzung-Bi Shih --- sound/soc/codecs/mt6358.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/mt6358.c