Re: [PATCH] ASoC: rsnd: don't double free kctrl

2016-12-08 Thread Kuninori Morimoto
Hi Colin > From: Colin Ian King > > On an error, snd_ctl_add already free's kctrl, so calling snd_ctl_free_one > to free it again leads to a double free error. Fix this by removing > the extraneous snd_ctl_free_one call. > > Issue found using static analysis with

Re: [PATCH] ASoC: rsnd: don't double free kctrl

2016-12-08 Thread Kuninori Morimoto
Hi Colin > From: Colin Ian King > > On an error, snd_ctl_add already free's kctrl, so calling snd_ctl_free_one > to free it again leads to a double free error. Fix this by removing > the extraneous snd_ctl_free_one call. > > Issue found using static analysis with CoverityScan, CID 1372908 >

[PATCH] ASoC: rsnd: don't double free kctrl

2016-12-08 Thread Colin King
From: Colin Ian King On an error, snd_ctl_add already free's kctrl, so calling snd_ctl_free_one to free it again leads to a double free error. Fix this by removing the extraneous snd_ctl_free_one call. Issue found using static analysis with CoverityScan, CID 1372908

[PATCH] ASoC: rsnd: don't double free kctrl

2016-12-08 Thread Colin King
From: Colin Ian King On an error, snd_ctl_add already free's kctrl, so calling snd_ctl_free_one to free it again leads to a double free error. Fix this by removing the extraneous snd_ctl_free_one call. Issue found using static analysis with CoverityScan, CID 1372908 Signed-off-by: Colin Ian