Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Mark Brown
On Fri, Nov 06, 2015 at 09:47:35PM +0100, Robert Jarzmik wrote: > Ok, so where I should target this code at ? Should this land in > sound/soc/soc-ac97.c ? Or somewhere else ? I'd like to see where you think the > init_gpio() and free_gpio() should be put. Sounds like a reasonable place, or

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Robert Jarzmik
Lee Jones writes: > On Fri, 06 Nov 2015, Charles Keepax wrote: > >> On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: >> > On Wed, 04 Nov 2015, Robert Jarzmik wrote: >> > >> > > Charles Keepax writes: >> > > >> > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: >>

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Lee Jones
On Fri, 06 Nov 2015, Charles Keepax wrote: > On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: > > On Wed, 04 Nov 2015, Robert Jarzmik wrote: > > > > > Charles Keepax writes: > > > > > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > > > >> The Wolfson WM9713

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Charles Keepax
On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: > On Wed, 04 Nov 2015, Robert Jarzmik wrote: > > > Charles Keepax writes: > > > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > > >>

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Lee Jones
On Wed, 04 Nov 2015, Robert Jarzmik wrote: > Charles Keepax writes: > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > >> kernel, declare a gpio chip. > >> > >> Signed-off-by: Robert Jarzmik > >>

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Lee Jones
On Wed, 04 Nov 2015, Robert Jarzmik wrote: > Charles Keepax writes: > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > >> kernel, declare a gpio chip. > >> > >>

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Charles Keepax
On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: > On Wed, 04 Nov 2015, Robert Jarzmik wrote: > > > Charles Keepax writes: > > > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > > >> The Wolfson WM9713 provides 8 GPIOs. If the

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Lee Jones
On Fri, 06 Nov 2015, Charles Keepax wrote: > On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: > > On Wed, 04 Nov 2015, Robert Jarzmik wrote: > > > > > Charles Keepax writes: > > > > > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Mark Brown
On Fri, Nov 06, 2015 at 09:47:35PM +0100, Robert Jarzmik wrote: > Ok, so where I should target this code at ? Should this land in > sound/soc/soc-ac97.c ? Or somewhere else ? I'd like to see where you think the > init_gpio() and free_gpio() should be put. Sounds like a reasonable place, or

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-06 Thread Robert Jarzmik
Lee Jones writes: > On Fri, 06 Nov 2015, Charles Keepax wrote: > >> On Fri, Nov 06, 2015 at 09:29:13AM +, Lee Jones wrote: >> > On Wed, 04 Nov 2015, Robert Jarzmik wrote: >> > >> > > Charles Keepax writes: >> > > >> > > > On Wed,

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-05 Thread Mark Brown
On Wed, Nov 04, 2015 at 06:33:22PM +, Charles Keepax wrote: > You should probably make a seperate driver within GPIO for this > and then tie the two together, using an MFD. I appreciate that is > more work but it is likely a nicer solution overall. GPIO chips are small and simple enough that

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-05 Thread Charles Keepax
On Wed, Nov 04, 2015 at 08:35:18PM +0100, Robert Jarzmik wrote: > Charles Keepax writes: > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > >> kernel, declare a gpio chip. > >> > >> Signed-off-by:

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-05 Thread Charles Keepax
On Wed, Nov 04, 2015 at 08:35:18PM +0100, Robert Jarzmik wrote: > Charles Keepax writes: > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > >> kernel, declare a

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-05 Thread Mark Brown
On Wed, Nov 04, 2015 at 06:33:22PM +, Charles Keepax wrote: > You should probably make a seperate driver within GPIO for this > and then tie the two together, using an MFD. I appreciate that is > more work but it is likely a nicer solution overall. GPIO chips are small and simple enough that

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
Charles Keepax writes: > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the >> kernel, declare a gpio chip. >> >> Signed-off-by: Robert Jarzmik >> --- > > You should probably make a seperate driver within

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Charles Keepax
On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > kernel, declare a gpio chip. > > Signed-off-by: Robert Jarzmik > --- You should probably make a seperate driver within GPIO for this and then tie the two

[PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the kernel, declare a gpio chip. Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 123 ++ sound/soc/codecs/wm9713.h | 1 + 2 files changed, 124 insertions(+) diff --git

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
Charles Keepax writes: > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the >> kernel, declare a gpio chip. >> >> Signed-off-by: Robert Jarzmik >>

[PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Robert Jarzmik
The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the kernel, declare a gpio chip. Signed-off-by: Robert Jarzmik --- sound/soc/codecs/wm9713.c | 123 ++ sound/soc/codecs/wm9713.h | 1 + 2 files changed, 124

Re: [PATCH] ASoC: wm9713: add gpio chip

2015-11-04 Thread Charles Keepax
On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: > The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the > kernel, declare a gpio chip. > > Signed-off-by: Robert Jarzmik > --- You should probably make a seperate driver within GPIO for this