Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc2 next-20160609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc2 next-20160609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc2 next-20160609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc2 next-20160609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hello Julian, It was an assumption on my part that the firmware supports a SET function. I realize it was premature to do so. I am sending another patch to convert the ath6kl_set_antenna() to a NO-OP. This will take care of the kernel warning, but would not fire any commands to firmware. I hope

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hello Julian, It was an assumption on my part that the firmware supports a SET function. I realize it was premature to do so. I am sending another patch to convert the ath6kl_set_antenna() to a NO-OP. This will take care of the kernel warning, but would not fire any commands to firmware. I hope

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi Prasun, On Thu, Jun 9, 2016 at 1:20 AM, Prasun Maiti wrote: > I am not sure it works fine. Like ath6kl driver send another cmd to > firmare, I have just filled up the cmd buffer with "tx_ant", and > "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi Prasun, On Thu, Jun 9, 2016 at 1:20 AM, Prasun Maiti wrote: > I am not sure it works fine. Like ath6kl driver send another cmd to > firmare, I have just filled up the cmd buffer with "tx_ant", and > "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd > buffer to firmware. >

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

On 06/08/2016 08:56 AM, Prasun Maiti wrote: Please help me how to test this one?? It will be great to me if you help me. I do not have time or interest, sorry. You basically need access to firmware source to do any useful development on this driver in my opinion, and I do not have access to

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

On 06/08/2016 08:56 AM, Prasun Maiti wrote: Please help me how to test this one?? It will be great to me if you help me. I do not have time or interest, sorry. You basically need access to firmware source to do any useful development on this driver in my opinion, and I do not have access to

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please help me how to test this one?? It will be great to me if you help me. On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear wrote: > On 06/08/2016 08:46 AM, Prasun Maiti wrote: >> >> Please tell me if I mention that this code is untested in commit log, >> then could you

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please help me how to test this one?? It will be great to me if you help me. On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear wrote: > On 06/08/2016 08:46 AM, Prasun Maiti wrote: >> >> Please tell me if I mention that this code is untested in commit log, >> then could you check the code kindly and

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

On 06/08/2016 08:46 AM, Prasun Maiti wrote: Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help me to fix this type of warning? In my experience, ath6kl has very fragile and buggy firmware, so I would not add any new API to

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

On 06/08/2016 08:46 AM, Prasun Maiti wrote: Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help me to fix this type of warning? In my experience, ath6kl has very fragile and buggy firmware, so I would not add any new API to

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help me to fix this type of warning? On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle wrote: > Prasun Maiti writes: > >> I am not sure

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help me to fix this type of warning? On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle wrote: > Prasun Maiti writes: > >> I am not sure it works fine. Like ath6kl driver send another

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Prasun Maiti writes: > I am not sure it works fine. Like ath6kl driver send another cmd to > firmare, I have just filled up the cmd buffer with "tx_ant", and > "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd > buffer to firmware. I have resend the

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Prasun Maiti writes: > I am not sure it works fine. Like ath6kl driver send another cmd to > firmare, I have just filled up the cmd buffer with "tx_ant", and > "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd > buffer to firmware. I have resend the patch as there are some

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

I am not sure it works fine. Like ath6kl driver send another cmd to firmare, I have just filled up the cmd buffer with "tx_ant", and "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd buffer to firmware. I have resend the patch as there are some errors in the previous patch. Let

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

I am not sure it works fine. Like ath6kl driver send another cmd to firmare, I have just filled up the cmd buffer with "tx_ant", and "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd buffer to firmware. I have resend the patch as there are some errors in the previous patch. Let

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Prasun Maiti writes: > No. I did not any test for that case. > This driver create a new wiphy for use with cfg80211 through > "wiphy_new_nm" api, but in this api, I found that more warnings for > inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && >

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Prasun Maiti writes: > No. I did not any test for that case. > This driver create a new wiphy for use with cfg80211 through > "wiphy_new_nm" api, but in this api, I found that more warnings for > inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && > !ops->get_antenna);" > So,

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.7-rc2 next-20160608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.7-rc2 next-20160608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

No. I did not any test for that case. This driver create a new wiphy for use with cfg80211 through "wiphy_new_nm" api, but in this api, I found that more warnings for inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && !ops->get_antenna);" So, warning comes during creation of a new

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

No. I did not any test for that case. This driver create a new wiphy for use with cfg80211 through "wiphy_new_nm" api, but in this api, I found that more warnings for inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && !ops->get_antenna);" So, warning comes during creation of a new

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Prasun Maiti writes: > Since add more warnings for inconsistent ops in cfg80211, the wireless > core warns if a driver implements a cfg80211 callback but doesn't > implements the inverse operation. The ath6kl driver implements a cfg80211 > .get_antenna operation handler

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Prasun Maiti writes: > Since add more warnings for inconsistent ops in cfg80211, the wireless > core warns if a driver implements a cfg80211 callback but doesn't > implements the inverse operation. The ath6kl driver implements a cfg80211 > .get_antenna operation handler but doesn't have the

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Since add more warnings for inconsistent ops in cfg80211, the wireless core warns if a driver implements a cfg80211 callback but doesn't implements the inverse operation. The ath6kl driver implements a cfg80211 .get_antenna operation handler but doesn't have the inverse .set_antenna callback. So,

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Since add more warnings for inconsistent ops in cfg80211, the wireless core warns if a driver implements a cfg80211 callback but doesn't implements the inverse operation. The ath6kl driver implements a cfg80211 .get_antenna operation handler but doesn't have the inverse .set_antenna callback. So,

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc2 next-20160608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Hi, [auto build test ERROR on ath6kl/ath-next] [also build test ERROR on v4.7-rc2 next-20160608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Since add more warnings for inconsistent ops in cfg80211, the wireless core warns if a driver implements a cfg80211 callback but doesn't implements the inverse operation. The ath6kl driver implements a cfg80211 .get_antenna operation handler but doesn't have the inverse .set_antenna callback. So,

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Since add more warnings for inconsistent ops in cfg80211, the wireless core warns if a driver implements a cfg80211 callback but doesn't implements the inverse operation. The ath6kl driver implements a cfg80211 .get_antenna operation handler but doesn't have the inverse .set_antenna callback. So,