Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On 04/18/2016 03:06 PM, Borislav Petkov wrote: On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote: the number of uncorrectable errors is useful from a system point of view. I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want to do that even for UEs

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On 04/18/2016 03:06 PM, Borislav Petkov wrote: On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote: the number of uncorrectable errors is useful from a system point of view. I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want to do that even for UEs

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On 04/18/2016 03:02 PM, Borislav Petkov wrote: On Mon, Apr 18, 2016 at 09:27:16AM -0500, Thor Thayer wrote: We're still getting the single bit correction By that you mean, you get that by enabling ECC on the FIFO block? Yes, you are correct. I'd still get the single bit correction by

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On 04/18/2016 03:02 PM, Borislav Petkov wrote: On Mon, Apr 18, 2016 at 09:27:16AM -0500, Thor Thayer wrote: We're still getting the single bit correction By that you mean, you get that by enabling ECC on the FIFO block? Yes, you are correct. I'd still get the single bit correction by

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote: > > the number of uncorrectable errors is useful from a system point of > > view. I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want to do that even for UEs coming from the network...? Seems a bit

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote: > > the number of uncorrectable errors is useful from a system point of > > view. I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want to do that even for UEs coming from the network...? Seems a bit

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Mon, Apr 18, 2016 at 09:27:16AM -0500, Thor Thayer wrote: > We're still getting the single bit correction By that you mean, you get that by enabling ECC on the FIFO block? > which makes the entire system more stable and the ability to see both > single bit errors corrected and the number of

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Mon, Apr 18, 2016 at 09:27:16AM -0500, Thor Thayer wrote: > We're still getting the single bit correction By that you mean, you get that by enabling ECC on the FIFO block? > which makes the entire system more stable and the ability to see both > single bit errors corrected and the number of

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

Hi Boris, On 04/15/2016 04:46 PM, Borislav Petkov wrote: On Fri, Apr 15, 2016 at 10:27:54AM -0500, Thor Thayer wrote: I'll update this patch to only count errors. ... and also think about what that counting is going to bring. If it is only going to be there to show how many network errors

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

Hi Boris, On 04/15/2016 04:46 PM, Borislav Petkov wrote: On Fri, Apr 15, 2016 at 10:27:54AM -0500, Thor Thayer wrote: I'll update this patch to only count errors. ... and also think about what that counting is going to bring. If it is only going to be there to show how many network errors

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Fri, Apr 15, 2016 at 10:27:54AM -0500, Thor Thayer wrote: > I'll update this patch to only count errors. ... and also think about what that counting is going to bring. If it is only going to be there to show how many network errors happened and we can't do anything about it except stare at

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Fri, Apr 15, 2016 at 10:27:54AM -0500, Thor Thayer wrote: > I'll update this patch to only count errors. ... and also think about what that counting is going to bring. If it is only going to be there to show how many network errors happened and we can't do anything about it except stare at

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On 04/15/2016 04:40 AM, Mauro Carvalho Chehab wrote: Em Thu, 14 Apr 2016 09:35:01 -0500 Rob Herring escreveu: On Tue, Apr 12, 2016 at 05:12:55PM -0500, ttha...@opensource.altera.com wrote: This patch set adds the memory initialization functions for Altera's Arria10

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On 04/15/2016 04:40 AM, Mauro Carvalho Chehab wrote: Em Thu, 14 Apr 2016 09:35:01 -0500 Rob Herring escreveu: On Tue, Apr 12, 2016 at 05:12:55PM -0500, ttha...@opensource.altera.com wrote: This patch set adds the memory initialization functions for Altera's Arria10 peripherals, the first

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

Em Thu, 14 Apr 2016 09:35:01 -0500 Rob Herring escreveu: > On Tue, Apr 12, 2016 at 05:12:55PM -0500, ttha...@opensource.altera.com wrote: > > This patch set adds the memory initialization functions for Altera's > > Arria10 peripherals, the first of which is the Ethernet EDAC.

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

Em Thu, 14 Apr 2016 09:35:01 -0500 Rob Herring escreveu: > On Tue, Apr 12, 2016 at 05:12:55PM -0500, ttha...@opensource.altera.com wrote: > > This patch set adds the memory initialization functions for Altera's > > Arria10 peripherals, the first of which is the Ethernet EDAC. The > > first 3

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Tue, Apr 12, 2016 at 05:12:55PM -0500, ttha...@opensource.altera.com wrote: > This patch set adds the memory initialization functions for Altera's > Arria10 peripherals, the first of which is the Ethernet EDAC. The > first 3 patches add the memory initialization functionality. The > last 3

Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

On Tue, Apr 12, 2016 at 05:12:55PM -0500, ttha...@opensource.altera.com wrote: > This patch set adds the memory initialization functions for Altera's > Arria10 peripherals, the first of which is the Ethernet EDAC. The > first 3 patches add the memory initialization functionality. The > last 3

[PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

This patch set adds the memory initialization functions for Altera's Arria10 peripherals, the first of which is the Ethernet EDAC. The first 3 patches add the memory initialization functionality. The last 3 patches add Ethernet EDAC support. [PATCH 1/6] EDAC, altera: Check parent status for

[PATCH] Add EDAC peripheral init functions & Ethernet EDAC.

This patch set adds the memory initialization functions for Altera's Arria10 peripherals, the first of which is the Ethernet EDAC. The first 3 patches add the memory initialization functionality. The last 3 patches add Ethernet EDAC support. [PATCH 1/6] EDAC, altera: Check parent status for