Greg KH wrote:
On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote:
And again, what does this buy us?
Clarity and simplicity, I hope... there are a bunch of definitions
scattered about the kernel that omit the __devinitdata modifier despite the
documentation stating that it should
On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote:
>> And again, what does this buy us?
>
> Clarity and simplicity, I hope... there are a bunch of definitions
> scattered about the kernel that omit the __devinitdata modifier despite the
> documentation stating that it should always be
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]>
---
include/linux/pci.h |9 +
1 files
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn [EMAIL PROTECTED]
---
include/linux/pci.h |9 +
1 files
On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote:
And again, what does this buy us?
Clarity and simplicity, I hope... there are a bunch of definitions
scattered about the kernel that omit the __devinitdata modifier despite the
documentation stating that it should always be there.
Greg KH wrote:
On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote:
And again, what does this buy us?
Clarity and simplicity, I hope... there are a bunch of definitions
scattered about the kernel that omit the __devinitdata modifier despite the
documentation stating that it should
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]>
---
include/linux/pci.h |9 +
1 files
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn [EMAIL PROTECTED]
---
include/linux/pci.h |9 +
1 files
And again, what does this buy us?
Clarity and simplicity, I hope... there are a bunch of definitions
scattered about the kernel that omit the __devinitdata modifier despite
the documentation stating that it should always be there. The
definition really should have been const, which wasn't
On Sun, Feb 17, 2008 at 01:13:24PM +0100, Jonas Bonn wrote:
> I'm a bit uncertain whether the definition really should include the
> 'static' modifier... for most definitions of these tables this is ok,
> but there are a couple of cases where it should not be static, so the
> line would need to be
On Sun, 17 Feb 2008 13:10:05 +0100 Jonas Bonn wrote:
> The definitions of struct pci_device_id arrays should generally follow
> the same pattern across the entire kernel. This macro defines this
> array as static const and puts it into the __devinitconst section.
>
> Signed-off-by: Jonas Bonn
I'm a bit uncertain whether the definition really should include the
'static' modifier... for most definitions of these tables this is ok,
but there are a couple of cases where it should not be static, so the
line would need to be open-coded again...
/Jonas
On Sun, 2008-02-17 at 13:10 +0100,
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as static const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn <[EMAIL PROTECTED]>
---
include/linux/pci.h |8
1
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as static const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn [EMAIL PROTECTED]
---
include/linux/pci.h |8
1
I'm a bit uncertain whether the definition really should include the
'static' modifier... for most definitions of these tables this is ok,
but there are a couple of cases where it should not be static, so the
line would need to be open-coded again...
/Jonas
On Sun, 2008-02-17 at 13:10 +0100,
On Sun, 17 Feb 2008 13:10:05 +0100 Jonas Bonn wrote:
The definitions of struct pci_device_id arrays should generally follow
the same pattern across the entire kernel. This macro defines this
array as static const and puts it into the __devinitconst section.
Signed-off-by: Jonas Bonn [EMAIL
On Sun, Feb 17, 2008 at 01:13:24PM +0100, Jonas Bonn wrote:
I'm a bit uncertain whether the definition really should include the
'static' modifier... for most definitions of these tables this is ok,
but there are a couple of cases where it should not be static, so the
line would need to be
And again, what does this buy us?
Clarity and simplicity, I hope... there are a bunch of definitions
scattered about the kernel that omit the __devinitdata modifier despite
the documentation stating that it should always be there. The
definition really should have been const, which wasn't
18 matches
Mail list logo
