Greg KH wrote:
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
+ if (hdr->id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
8, + (nic->pci_bdf & 0xff));
pci_get_bus_and_slot fails in
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
> > > + if (hdr->id == id_nic) {
> > > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
> > > 8, + (nic->pci_bdf & 0xff));
> > pci_get_bus_and_slot fails in
> > + if (hdr->id == id_nic) {
> > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
> > 8, + (nic->pci_bdf & 0xff));
> pci_get_bus_and_slot fails in the presence of PCI domains, which are
> getting to be fairly common even
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00)
8, + (nic-pci_bdf 0xff));
pci_get_bus_and_slot fails in the presence of
Greg KH wrote:
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00)
8, + (nic-pci_bdf 0xff));
pci_get_bus_and_slot fails in the
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00)
8, + (nic-pci_bdf 0xff));
pci_get_bus_and_slot fails in the presence of PCI domains, which are
getting to be fairly common even in medium
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> + if (hdr->id == id_nic) {
> + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8,
> + (nic->pci_bdf & 0xff));
> + if (pci_dev) {
> +
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> + ibft_device = kmalloc(len, GFP_KERNEL);
> + if (!ibft_device)
> + return -ENOMEM;
> +
> + memcpy(ibft_device, hdr, len);
This piece looks a bit odd. you're making ibft_device an exact
duplicate of
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> +/*
> + * Physical location of iSCSI Boot Format Table.
This is now the Virtual address, isn't it? So just drop the Physical.
> + */
> +unsigned long ibft_addr;
> +EXPORT_SYMBOL(ibft_addr);
And since it is the virtual address,
Whoops. I've attached an incorrect patch in the previous
e-mail (http://lkml.org/lkml/2008/2/8/350) that didn't take
in to account the 'reserve_bootmem' parameters changes.
Here is fresher copy which has been tested on 2.6.24-git19
on a machine with iBFT and without.
This patch (v0.4.7) adds
This patch (v0.4.7) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
Whoops. I've attached an incorrect patch in the previous
e-mail (http://lkml.org/lkml/2008/2/8/350) that didn't take
in to account the 'reserve_bootmem' parameters changes.
Here is fresher copy which has been tested on 2.6.24-git19
on a machine with iBFT and without.
This patch (v0.4.7) adds
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
+/*
+ * Physical location of iSCSI Boot Format Table.
This is now the Virtual address, isn't it? So just drop the Physical.
+ */
+unsigned long ibft_addr;
+EXPORT_SYMBOL(ibft_addr);
And since it is the virtual address, there's no
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
+ ibft_device = kmalloc(len, GFP_KERNEL);
+ if (!ibft_device)
+ return -ENOMEM;
+
+ memcpy(ibft_device, hdr, len);
This piece looks a bit odd. you're making ibft_device an exact
duplicate of ibft_addr
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00) 8,
+ (nic-pci_bdf 0xff));
+ if (pci_dev) {
+ rc =
This patch (v0.4.7) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
16 matches
Mail list logo
