On Thu, Feb 12, 2015 at 08:46:51AM -, Mark Glover wrote:
> Sorry, no difference just ignorance on my part.
> I had the impression having just missed one release I needed to resubmit the
> patch.
No, I'm still waiting for you to answer my comments on your patch.
Mostly some clarifications
; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added Pids for Actisense Usb Devices
On Wed, Feb 11, 2015 at 10:49:47AM +, Mark Glover wrote:
> From: Mark Glover
>
> Signed-off-by: Mark Glover
What is different from your
; gre...@linuxfoundation.org; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added Pids for Actisense Usb Devices
On Wed, Feb 11, 2015 at 10:49:47AM +, Mark Glover wrote:
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
What
On Thu, Feb 12, 2015 at 08:46:51AM -, Mark Glover wrote:
Sorry, no difference just ignorance on my part.
I had the impression having just missed one release I needed to resubmit the
patch.
No, I'm still waiting for you to answer my comments on your patch.
Mostly some clarifications needed.
On Wed, Feb 11, 2015 at 10:49:47AM +, Mark Glover wrote:
> From: Mark Glover
>
> Signed-off-by: Mark Glover
What is different from your previous version? Please address my comments
to that one before resending.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe
From: Mark Glover
Signed-off-by: Mark Glover
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index
On Wed, Feb 11, 2015 at 10:49:47AM +, Mark Glover wrote:
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
What is different from your previous version? Please address my comments
to that one before resending.
Thanks,
Johan
--
To unsubscribe from this
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c
On Thu, Jan 15, 2015 at 08:34:34AM +, Mark Glover wrote:
> From: Mark Glover
>
> Signed-off-by: Mark Glover
Thanks for the patch and for addressing Peter's comments.
A couple of minor nits: Please use a subsystem prefix for your patch
summary, for example:
"USB: ftdi_sio: add
On Thu, Jan 15, 2015 at 08:34:34AM +, Mark Glover wrote:
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
Thanks for the patch and for addressing Peter's comments.
A couple of minor nits: Please use a subsystem prefix for your patch
summary, for example:
From: Mark Glover
Signed-off-by: Mark Glover
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c
Mark Glover wrote:
> From: Mark Glover
>
> Signed-off-by: Mark Glover
There's an extraneous leading whitespace on the Signed-off-by line.
> +#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Apadter */
The typo remains. "Apadter" here ^
//Peter
From: Mark Glover
Signed-off-by: Mark Glover
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index
Please update your commit message to leave one blank line between the
commit message summary and the rest of the message. (This avoids your
signed-off-by ending up in the email subject.)
Mark Glover wrote:
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
..
> +#define CHETCO_SEAGAUGE_PID 0xA548
From: Mark Glover
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 1ebb351..a118e5b 100644
---
Mark Glover wrote:
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
There's an extraneous leading whitespace on the Signed-off-by line.
+#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Apadter */
The typo remains. Apadter here
From: Mark Glover m...@actisense.com
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index
Please update your commit message to leave one blank line between the
commit message summary and the rest of the message. (This avoids your
signed-off-by ending up in the email subject.)
Mark Glover wrote:
+++ b/drivers/usb/serial/ftdi_sio_ids.h
..
+#define CHETCO_SEAGAUGE_PID 0xA548
From: Mark Glover m...@actisense.com
Signed-off-by: Mark Glover m...@actisense.com
---
drivers/usb/serial/ftdi_sio.c | 17 +
drivers/usb/serial/ftdi_sio_ids.h | 21 +
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c
20 matches
Mail list logo
