Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2016-01-05 Thread David Sterba
On Wed, Dec 30, 2015 at 04:21:47PM -0500, Sanidhya Solanki wrote: > On Wed, 30 Dec 2015 17:17:22 +0100 > David Sterba wrote: > > > Let me note that a good reputation is also built from patch reviews > > (hint hint). > > Unfortunately, not too many patches coming in for BTRFS presently. > Mailing

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2016-01-05 Thread David Sterba
On Thu, Dec 31, 2015 at 08:46:36AM +0800, Qu Wenruo wrote: > > Let me note that a good reputation is also built from patch reviews > > (hint hint). > > I must admit I'm a bad reviewer. > As when I review something, I always has an eager to rewrite part or all > the patch to follow my idea, even i

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Sanidhya Solanki
On Wed, 30 Dec 2015 17:17:22 +0100 David Sterba wrote: > Let me note that a good reputation is also built from patch reviews > (hint hint). Unfortunately, not too many patches coming in for BTRFS presently. Mailing list activity is down to 25-35 mails per day. Mostly feature and bug requests. I

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Sanidhya Solanki
On Wed, 30 Dec 2015 16:58:05 +0100 David Sterba wrote: > On Wed, Dec 30, 2015 at 06:15:23AM -0500, Sanidhya Solanki wrote: > > - Implement a way to do an in-place Stripe Length change. > > How are you going to implement that? I've suggested the balance filter > style of conversion, which is not

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Qu Wenruo
David Sterba wrote on 2015/12/30 17:17 +0100: On Wed, Dec 30, 2015 at 10:10:44PM +0800, Qu Wenruo wrote: Now I am on the same side of David. Which means a runtime interface to change them. (along with mkfs option) If provide some configurable features, then it should be able to be tuned at bo

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread David Sterba
On Wed, Dec 30, 2015 at 10:10:44PM +0800, Qu Wenruo wrote: > Now I am on the same side of David. > Which means a runtime interface to change them. (along with mkfs option) > > If provide some configurable features, then it should be able to be > tuned at both right time and mkfs time. > Or, just

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread David Sterba
On Wed, Dec 30, 2015 at 06:15:23AM -0500, Sanidhya Solanki wrote: > Only one problem. I do not run BTRFS on my systems nor do I have a > RAID setup, due to possessing a limited number of free drives. So, while > I may be able to code for it, I will not be able to test it. I will need > the communit

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Sanidhya Solanki
On Wed, 30 Dec 2015 22:10:44 +0800 Qu Wenruo wrote: > Understood now. Good. > I totally understand that implement ... to polish your > skill. That has got to be the most hilarious way I believe I have seen someone delegate a task. But it was effective. Only one problem. I do not run BTRFS on m

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Qu Wenruo
On 12/30/2015 05:54 PM, Sanidhya Solanki wrote: On Wed, 30 Dec 2015 19:59:16 +0800 Qu Wenruo wrote: Not really sure about the difference between 2 and 3. I should have made it clear before, I was asking the exact use case in mind when listing the choices. Option 2 would be for SysAdmins run

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Sanidhya Solanki
On Wed, 30 Dec 2015 19:59:16 +0800 Qu Wenruo wrote: > Not really sure about the difference between 2 and 3. I should have made it clear before, I was asking the exact use case in mind when listing the choices. Option 2 would be for SysAdmins running production software and configuring it as they

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Qu Wenruo
On 12/30/2015 02:39 PM, Sanidhya Solanki wrote: On Tue, 29 Dec 2015 18:06:11 +0100 David Sterba wrote: So you want to make the stripe size configurable?... As I see it there are 3 ways to do it: -Make it a compile time option that only configures it for a single system with any devices tha

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-30 Thread Sanidhya Solanki
On Tue, 29 Dec 2015 18:06:11 +0100 David Sterba wrote: > So you want to make the stripe size configurable?... As I see it there are 3 ways to do it: -Make it a compile time option that only configures it for a single system with any devices that are added to the RAID. -Make it a runtime option t

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-29 Thread Sanidhya Solanki
On Tue, 29 Dec 2015 18:06:11 +0100 David Sterba wrote: > I don't know about all implications from changing the define to > sb->stripesize, also we want to define the allowed range etc. It would > be better to add more description to the patch. So, is the patch atleast somewhat usable and you jus

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-29 Thread David Sterba
On Tue, Dec 29, 2015 at 06:15:12AM -0500, Sanidhya Solanki wrote: > On Tue, 29 Dec 2015 14:39:07 +0100 > David Sterba wrote: > > > The stripe size depends on how the filesystem was made, at the moment > > the stripesize parameter is missing from mkfs. The kernel module > > should support all size

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-29 Thread Sanidhya Solanki
On Tue, 29 Dec 2015 14:39:07 +0100 David Sterba wrote: > The stripe size depends on how the filesystem was made, at the moment > the stripesize parameter is missing from mkfs. The kernel module > should support all sizes at runtime, so it's not a compile-time > option. No good? I will try and re

Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-29 Thread David Sterba
On Mon, Dec 28, 2015 at 07:24:11AM -0500, Sanidhya Solanki wrote: > An option to select the RAID Stripe size is made > available in the BTRFS Filesystem, via an option > in the BTRFS Config setup, with minimal change > to the existing code base. The stripe size depends on how the filesystem was ma

[PATCH] BTRFS: Adds an option to select RAID Stripe size

2015-12-28 Thread Sanidhya Solanki
An option to select the RAID Stripe size is made available in the BTRFS Filesystem, via an option in the BTRFS Config setup, with minimal change to the existing code base. Signed-off-by: Sanidhya Solanki --- fs/btrfs/Kconfig | 42 ++ fs/btrfs/Makefile |