Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-26 Thread James Bottomley
On Thu, 2007-04-26 at 11:04 -0400, Alan Stern wrote: > On Thu, 26 Apr 2007, Joerg Schilling wrote: > > > Any chance to that this bug will be fixed anytime soon? > > > > The Bug has been reported February 2004 but is still not fixed in sg.c > > Is Linux development really so slow? > >

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-26 Thread Alan Stern
On Thu, 26 Apr 2007, Joerg Schilling wrote: > Any chance to that this bug will be fixed anytime soon? > > The Bug has been reported February 2004 but is still not fixed in sg.c > Is Linux development really so slow? Douglas Gilbert has signed off on the patch. There doesn't appear to have

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-26 Thread Joerg Schilling
Any chance to that this bug will be fixed anytime soon? The Bug has been reported February 2004 but is still not fixed in sg.c Is Linux development really so slow? Douglas Gilbert <[EMAIL PROTECTED]> wrote: > Alan, > The SG_GET_RESERVED_SIZE ioctl is also defined in > the block layer, see

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-26 Thread Joerg Schilling
Any chance to that this bug will be fixed anytime soon? The Bug has been reported February 2004 but is still not fixed in sg.c Is Linux development really so slow? Douglas Gilbert [EMAIL PROTECTED] wrote: Alan, The SG_GET_RESERVED_SIZE ioctl is also defined in the block layer, see

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-26 Thread Alan Stern
On Thu, 26 Apr 2007, Joerg Schilling wrote: Any chance to that this bug will be fixed anytime soon? The Bug has been reported February 2004 but is still not fixed in sg.c Is Linux development really so slow? Douglas Gilbert has signed off on the patch. There doesn't appear to have

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-26 Thread James Bottomley
On Thu, 2007-04-26 at 11:04 -0400, Alan Stern wrote: On Thu, 26 Apr 2007, Joerg Schilling wrote: Any chance to that this bug will be fixed anytime soon? The Bug has been reported February 2004 but is still not fixed in sg.c Is Linux development really so slow? Douglas Gilbert

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread James Bottomley
On Mon, 2007-04-02 at 16:23 +0200, Jens Axboe wrote: > FWIW, it had my ack, I think we were just waiting for Doug to ack the sg > bits. And there's really nothing I can do (well, except write the thing) since the changes are not in any SCSI pieces I maintain directly ... they're block and sg.

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread Jens Axboe
On Mon, Apr 02 2007, Alan Stern wrote: > On Mon, 2 Apr 2007, Joerg Schilling wrote: > > > Hi, > > > > this is a repost as I like to know the current state of the problem... > > > > The USB DMA size problem is known to exist on Linux since February 2004. > > I am still in hope that there will be

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread Alan Stern
On Mon, 2 Apr 2007, Joerg Schilling wrote: > Hi, > > this is a repost as I like to know the current state of the problem... > > The USB DMA size problem is known to exist on Linux since February 2004. > I am still in hope that there will be a fix soon. Me too. I submitted the most recent

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread Joerg Schilling
Hi, this is a repost as I like to know the current state of the problem... The USB DMA size problem is known to exist on Linux since February 2004. I am still in hope that there will be a fix soon. /*--*/ Alan Stern <[EMAIL

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread Joerg Schilling
Hi, this is a repost as I like to know the current state of the problem... The USB DMA size problem is known to exist on Linux since February 2004. I am still in hope that there will be a fix soon. /*--*/ Alan Stern [EMAIL

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread Alan Stern
On Mon, 2 Apr 2007, Joerg Schilling wrote: Hi, this is a repost as I like to know the current state of the problem... The USB DMA size problem is known to exist on Linux since February 2004. I am still in hope that there will be a fix soon. Me too. I submitted the most recent version of

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread Jens Axboe
On Mon, Apr 02 2007, Alan Stern wrote: On Mon, 2 Apr 2007, Joerg Schilling wrote: Hi, this is a repost as I like to know the current state of the problem... The USB DMA size problem is known to exist on Linux since February 2004. I am still in hope that there will be a fix soon.

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread James Bottomley
On Mon, 2007-04-02 at 16:23 +0200, Jens Axboe wrote: FWIW, it had my ack, I think we were just waiting for Doug to ack the sg bits. And there's really nothing I can do (well, except write the thing) since the changes are not in any SCSI pieces I maintain directly ... they're block and sg.

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-20 Thread Alan Stern
On Mon, 19 Feb 2007, Douglas Gilbert wrote: > > Come to think of it, the reserved_size value used when a new sg device is > > created should also be capped at max_sectors * 512. Agreed? I can't see > > any reason for ever having a larger buffer -- it would be impossible to > > make use of the

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-20 Thread Alan Stern
On Mon, 19 Feb 2007, Douglas Gilbert wrote: Come to think of it, the reserved_size value used when a new sg device is created should also be capped at max_sectors * 512. Agreed? I can't see any reason for ever having a larger buffer -- it would be impossible to make use of the extra

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Douglas Gilbert
Alan Stern wrote: > On Mon, 19 Feb 2007, Douglas Gilbert wrote: > >> Alan, >> The SG_GET_RESERVED_SIZE ioctl is also defined in >> the block layer, see block/scsi_ioctl.c . > > Ah, I didn't know that. (Or more likely, I used to know and have since > forgotten.) Thanks for pointing it out. >

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Mon, 19 Feb 2007, Douglas Gilbert wrote: > Alan, > The SG_GET_RESERVED_SIZE ioctl is also defined in > the block layer, see block/scsi_ioctl.c . Ah, I didn't know that. (Or more likely, I used to know and have since forgotten.) Thanks for pointing it out. > I suspect it is just a kludge

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Douglas Gilbert
Alan Stern wrote: > On Mon, 19 Feb 2007, Joerg Schilling wrote: > >> Alan Stern <[EMAIL PROTECTED]> wrote: >> >>> Well, if Doug wants to reduce the value returned by SG_GET_RESERVED_SIZE, >>> it's okay with me. An advantage of doing this is that older versions of >>> cdrecord would then work

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Mon, 19 Feb 2007, Joerg Schilling wrote: > Alan Stern <[EMAIL PROTECTED]> wrote: > > > Well, if Doug wants to reduce the value returned by SG_GET_RESERVED_SIZE, > > it's okay with me. An advantage of doing this is that older versions of > > cdrecord would then work correctly. > > > >

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Joerg Schilling
Alan Stern <[EMAIL PROTECTED]> wrote: > Well, if Doug wants to reduce the value returned by SG_GET_RESERVED_SIZE, > it's okay with me. An advantage of doing this is that older versions of > cdrecord would then work correctly. > > However you don't seem to realize that people can use programs

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Sun, 18 Feb 2007, Joerg Schilling wrote: > Alan Stern <[EMAIL PROTECTED]> wrote: > > > > Alternatively the SG_GET_RESERVED_SIZE ioctl could be > > > modified to yield no more than max_sectors*512 . > > > > There should be one single ioctl which can be applied uniformly to all > > CD-type

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Sun, 18 Feb 2007, Joerg Schilling wrote: Alan Stern [EMAIL PROTECTED] wrote: Alternatively the SG_GET_RESERVED_SIZE ioctl could be modified to yield no more than max_sectors*512 . There should be one single ioctl which can be applied uniformly to all CD-type devices (in fact, to

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Joerg Schilling
Alan Stern [EMAIL PROTECTED] wrote: Well, if Doug wants to reduce the value returned by SG_GET_RESERVED_SIZE, it's okay with me. An advantage of doing this is that older versions of cdrecord would then work correctly. However you don't seem to realize that people can use programs like

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Mon, 19 Feb 2007, Joerg Schilling wrote: Alan Stern [EMAIL PROTECTED] wrote: Well, if Doug wants to reduce the value returned by SG_GET_RESERVED_SIZE, it's okay with me. An advantage of doing this is that older versions of cdrecord would then work correctly. However you don't

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Douglas Gilbert
Alan Stern wrote: On Mon, 19 Feb 2007, Joerg Schilling wrote: Alan Stern [EMAIL PROTECTED] wrote: Well, if Doug wants to reduce the value returned by SG_GET_RESERVED_SIZE, it's okay with me. An advantage of doing this is that older versions of cdrecord would then work correctly.

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Alan Stern
On Mon, 19 Feb 2007, Douglas Gilbert wrote: Alan, The SG_GET_RESERVED_SIZE ioctl is also defined in the block layer, see block/scsi_ioctl.c . Ah, I didn't know that. (Or more likely, I used to know and have since forgotten.) Thanks for pointing it out. I suspect it is just a kludge to

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-19 Thread Douglas Gilbert
Alan Stern wrote: On Mon, 19 Feb 2007, Douglas Gilbert wrote: Alan, The SG_GET_RESERVED_SIZE ioctl is also defined in the block layer, see block/scsi_ioctl.c . Ah, I didn't know that. (Or more likely, I used to know and have since forgotten.) Thanks for pointing it out. I suspect

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-18 Thread Joerg Schilling
Alan Stern <[EMAIL PROTECTED]> wrote: > > Alternatively the SG_GET_RESERVED_SIZE ioctl could be > > modified to yield no more than max_sectors*512 . > > There should be one single ioctl which can be applied uniformly to all > CD-type devices (in fact, to all devices using a request_queue) to

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-18 Thread Alan Stern
On Sat, 17 Feb 2007, Douglas Gilbert wrote: > Jens Axboe wrote: > > On Fri, Feb 16 2007, Alan Stern wrote: > >> From: James Bottomley <[EMAIL PROTECTED]> > >> > >> This patch (as854) separates out the two queue-oriented ioctls from > >> the rest of the block-layer ioctls. The idea is that they

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-18 Thread Joerg Schilling
Douglas Gilbert <[EMAIL PROTECTED]> wrote: > Jens Axboe wrote: > > On Fri, Feb 16 2007, Alan Stern wrote: > >> From: James Bottomley <[EMAIL PROTECTED]> > >> > >> This patch (as854) separates out the two queue-oriented ioctls from > >> the rest of the block-layer ioctls. The idea is that they

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-18 Thread Joerg Schilling
Douglas Gilbert [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Fri, Feb 16 2007, Alan Stern wrote: From: James Bottomley [EMAIL PROTECTED] This patch (as854) separates out the two queue-oriented ioctls from the rest of the block-layer ioctls. The idea is that they should apply to any

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-18 Thread Alan Stern
On Sat, 17 Feb 2007, Douglas Gilbert wrote: Jens Axboe wrote: On Fri, Feb 16 2007, Alan Stern wrote: From: James Bottomley [EMAIL PROTECTED] This patch (as854) separates out the two queue-oriented ioctls from the rest of the block-layer ioctls. The idea is that they should apply to

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-18 Thread Joerg Schilling
Alan Stern [EMAIL PROTECTED] wrote: Alternatively the SG_GET_RESERVED_SIZE ioctl could be modified to yield no more than max_sectors*512 . There should be one single ioctl which can be applied uniformly to all CD-type devices (in fact, to all devices using a request_queue) to learn

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-17 Thread Douglas Gilbert
Jens Axboe wrote: > On Fri, Feb 16 2007, Alan Stern wrote: >> From: James Bottomley <[EMAIL PROTECTED]> >> >> This patch (as854) separates out the two queue-oriented ioctls from >> the rest of the block-layer ioctls. The idea is that they should >> apply to any driver using a request_queue, even

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-17 Thread Joerg Schilling
Jens Axboe <[EMAIL PROTECTED]> wrote: > > This will make it possible for cdrecord and related programs to > > retrieve reliably the max_sectors value, regardless of whether the > > user points it to an sr or an sg device. In particular, this will > > resolve Bugzilla entry #7026. > > The block

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-17 Thread Joerg Schilling
Jens Axboe [EMAIL PROTECTED] wrote: This will make it possible for cdrecord and related programs to retrieve reliably the max_sectors value, regardless of whether the user points it to an sr or an sg device. In particular, this will resolve Bugzilla entry #7026. The block bits are fine

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-17 Thread Douglas Gilbert
Jens Axboe wrote: On Fri, Feb 16 2007, Alan Stern wrote: From: James Bottomley [EMAIL PROTECTED] This patch (as854) separates out the two queue-oriented ioctls from the rest of the block-layer ioctls. The idea is that they should apply to any driver using a request_queue, even if the driver

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-16 Thread Jens Axboe
On Fri, Feb 16 2007, Alan Stern wrote: > From: James Bottomley <[EMAIL PROTECTED]> > > This patch (as854) separates out the two queue-oriented ioctls from > the rest of the block-layer ioctls. The idea is that they should > apply to any driver using a request_queue, even if the driver doesn't >

[PATCH] Block layer: separate out queue-oriented ioctls

2007-02-16 Thread Alan Stern
From: James Bottomley <[EMAIL PROTECTED]> This patch (as854) separates out the two queue-oriented ioctls from the rest of the block-layer ioctls. The idea is that they should apply to any driver using a request_queue, even if the driver doesn't implement a block-device interface. The

[PATCH] Block layer: separate out queue-oriented ioctls

2007-02-16 Thread Alan Stern
From: James Bottomley [EMAIL PROTECTED] This patch (as854) separates out the two queue-oriented ioctls from the rest of the block-layer ioctls. The idea is that they should apply to any driver using a request_queue, even if the driver doesn't implement a block-device interface. The prototypical

Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-02-16 Thread Jens Axboe
On Fri, Feb 16 2007, Alan Stern wrote: From: James Bottomley [EMAIL PROTECTED] This patch (as854) separates out the two queue-oriented ioctls from the rest of the block-layer ioctls. The idea is that they should apply to any driver using a request_queue, even if the driver doesn't