Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-28 Thread Oliver Neukum
Am Donnerstag, den 24.09.2020, 20:33 -0700 schrieb Abhishek Pandit- Subedi: > Runtime suspend always requires remote wakeup to be set No, not entirely. Btusb requires remote wakeup between open() and close(). On a closed device it is not set to save more power. > and reset > resume isn't used

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 16:23, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On September 25, 2020 at 15:56, Kai-Heng Feng wrote: >> >> Hi Alex, >> >>> On Sep 25, 2020, at 15:42, 陆朱伟 wrote: >>> >>> Hi Kai-Heng, >>> On 25 September 2020 at 15:14, Kai-Heng Feng wrote: Hi Alex, >>

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread 陆朱伟
Hi Kai-Heng, > On September 25, 2020 at 15:56, Kai-Heng Feng wrote: > > Hi Alex, > > > On Sep 25, 2020, at 15:42, 陆朱伟 wrote: > > > > Hi Kai-Heng, > > > >> On 25 September 2020 at 15:14, Kai-Heng Feng wrote: > >> > >> Hi Alex, > > [snipped] > > >> Apparently for my case, RTL8821CE, firmware

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 15:42, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On 25 September 2020 at 15:14, Kai-Heng Feng wrote: >> >> Hi Alex, [snipped] >> Apparently for my case, RTL8821CE, firmware was kept without setting >> remote wakeup. > > So you got the btusb disconnect and reprobe

答复: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread 陆朱伟
Hi Kai-Heng, > On 25 September 2020 at 15:14, Kai-Heng Feng wrote: > > Hi Alex, > > > On Sep 25, 2020, at 15:04, 陆朱伟 wrote: > > > > Hi Kai-Heng, > > > >> On September 25, 2020 14:04, Kai-Heng Feng wrote: > >> > >> Hi Abhishek, > >>> On Sep 25, 2020, at 11:33, Abhishek Pandit-Subedi > >>

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 15:04, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On September 25, 2020 14:04, Kai-Heng Feng wrote: >> >> Hi Abhishek, >>> On Sep 25, 2020, at 11:33, Abhishek Pandit-Subedi >> wrote: >>> >>> + Alex Lu (who contributed the original change) >>> >>> Hi Kai-Heng, >>> >>>

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread 陆朱伟
Hi Kai-Heng, > On September 25, 2020 14:04, Kai-Heng Feng wrote: > > Hi Abhishek, > > On Sep 25, 2020, at 11:33, Abhishek Pandit-Subedi > wrote: > > > > + Alex Lu (who contributed the original change) > > > > Hi Kai-Heng, > > > > > > On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng > > wrote: >

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
> On Sep 25, 2020, at 14:40, 陆朱伟 wrote: > > Hi Abhishek, > >> On September 25, 2020 at 11:34, Abhishek Pandit-Subedi wrote: >> >> + Alex Lu (who contributed the original change) >> >> Hi Kai-Heng, >> >> >> On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng >> wrote: >>> >>> [+Cc linux-usb]

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread 陆朱伟
Hi Abhishek, > On September 25, 2020 at 11:34, Abhishek Pandit-Subedi wrote: > > + Alex Lu (who contributed the original change) > > Hi Kai-Heng, > > > On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng > wrote: > > > > [+Cc linux-usb] > > > > Hi Abhishek, > > > > > On Sep 24, 2020, at 04:41,

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Abhishek, > On Sep 25, 2020, at 11:33, Abhishek Pandit-Subedi > wrote: > > + Alex Lu (who contributed the original change) > > Hi Kai-Heng, > > > On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng > wrote: >> >> [+Cc linux-usb] >> >> Hi Abhishek, >> >>> On Sep 24, 2020, at 04:41, Abhishek

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-24 Thread Abhishek Pandit-Subedi
+ Alex Lu (who contributed the original change) Hi Kai-Heng, On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng wrote: > > [+Cc linux-usb] > > Hi Abhishek, > > > On Sep 24, 2020, at 04:41, Abhishek Pandit-Subedi > > wrote: > > > > Hi Kai-Heng, > > > > Which Realtek controller is this on?' > >

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-24 Thread Kai-Heng Feng
[+Cc linux-usb] Hi Abhishek, > On Sep 24, 2020, at 04:41, Abhishek Pandit-Subedi > wrote: > > Hi Kai-Heng, > > Which Realtek controller is this on?' The issue happens on 8821CE. > > Specifically for RTL8822CE, we tested without reset_resume being set > and that was causing the controller

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-23 Thread Abhishek Pandit-Subedi
Hi Kai-Heng, Which Realtek controller is this on? Specifically for RTL8822CE, we tested without reset_resume being set and that was causing the controller being reset without bluez ever learning about it (resulting in devices being unusable without toggling the BT power). If the firmware doesn't

[PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-23 Thread Kai-Heng Feng
Realtek bluetooth controller may fail to work after system sleep: [ 1272.707670] Bluetooth: hci0: command 0x1001 tx timeout [ 1280.835712] Bluetooth: hci0: RTL: HCI_OP_READ_LOCAL_VERSION failed (-110) If platform firmware doesn't cut power off during suspend, the firmware is considered retained