Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-30 Thread Gioh Kim
2014-07-22 오전 10:04, Gioh Kim 쓴 글: 2014-07-22 오전 9:15, Minchan Kim 쓴 글: Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-30 Thread Gioh Kim
2014-07-22 오전 10:04, Gioh Kim 쓴 글: 2014-07-22 오전 9:15, Minchan Kim 쓴 글: Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Gioh Kim
2014-07-22 오전 9:15, Minchan Kim 쓴 글: Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two things popped out at me during the

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Minchan Kim
Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: > On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: > > I'm not reviewing this in detail at all, didn't even look at the patch > but two things popped out at me during the discussion. > > > > >Anyway, why cannot

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Mel Gorman
On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two things popped out at me during the discussion. > > >Anyway, why cannot CMA have the cost without affecting other subsystem? > > >I mean it's okay for CMA to

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Minchan Kim
w. > > SO I do not want to touch non-CMA related code. > > I'm not saying to add hook in drop_buffers. > What I suggest is to handle failure by bh_lrus in migrate_pages > because it's not a problem only in CMA. > There is already retry logic in migrate_pages so I can think

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Minchan Kim
hat I suggest is to handle failure by bh_lrus in migrate_pages because it's not a problem only in CMA. There is already retry logic in migrate_pages so I can think you could handle it. > > > > > >>The try_to_free_buffers() which is calling drop_buffers() is called by many > >>fi

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Gioh Kim
s for any feedback. --- 8< -- >From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Gioh Kim
. --- 8 -- From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Minchan Kim
buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so that the bh of lru must be freed before migrating the page. This frees every bh of lru. We could free only bh of migrating

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Minchan Kim
. --- 8 -- From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Mel Gorman
On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two things popped out at me during the discussion. Anyway, why cannot CMA have the cost without affecting other subsystem? I mean it's okay for CMA to

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Minchan Kim
Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two things popped out at me during the discussion. Anyway, why cannot CMA have

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-21 Thread Gioh Kim
2014-07-22 오전 9:15, Minchan Kim 쓴 글: Hello Mel, On Mon, Jul 21, 2014 at 02:01:46PM +0100, Mel Gorman wrote: On Mon, Jul 21, 2014 at 04:36:51PM +0900, Minchan Kim wrote: I'm not reviewing this in detail at all, didn't even look at the patch but two things popped out at me during the

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-20 Thread Minchan Kim
> --- 8< ------------------ > > >From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 > From: Gioh Kim > Date: Fri, 18 Jul 2014 13:40:01 +0900 > Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page mig

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-20 Thread Minchan Kim
] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so that the bh of lru must be freed before migrating the page. This frees every bh of lru. We could

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-19 Thread Michal Nazarewicz
>> On 2014-07-18 08:45, Gioh Kim wrote: >>> From: Gioh Kim >>> Date: Fri, 18 Jul 2014 13:40:01 +0900 >>> Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration >>> >>> The bh must be free to migrate a page at which bh is mapp

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-19 Thread Michal Nazarewicz
On 2014-07-18 08:45, Gioh Kim wrote: From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Laura Abbott
> > Laura, can I have you name on Acked-by line? > Please let me represent my thanks. > > Thanks for any feedback. > > --- 8< ------------------ > > From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 > From: G

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Zhang Yanfei
inguish migration type and invalidate >>> lru if it needs. >>> I think alloc_contig_range() is proper to deal with bh like following patch. >>> >>> Laura, can I have you name on Acked-by line? >>> Please let me represent my thanks. >>> >>&g

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Gioh Kim
-- >From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Marek Szyprowski
0:00 2001 From: Gioh Kim Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so that the bh of lru must b

[PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Gioh Kim
Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so that the bh of lru must be freed before migrating the page. This f

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Laura Abbott
33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when

[PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Gioh Kim
+0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so that the bh of lru must be freed before migrating the page. This frees every bh

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Marek Szyprowski
@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so that the bh of lru must be freed before

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Gioh Kim
Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate a page at which bh is mapped. The reference count of bh is increased when it is installed into lru so

Re: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration

2014-07-18 Thread Zhang Yanfei
. --- 8 -- From 33c894b1bab9bc26486716f0c62c452d3a04d35d Mon Sep 17 00:00:00 2001 From: Gioh Kim gioh@lge.com Date: Fri, 18 Jul 2014 13:40:01 +0900 Subject: [PATCH] CMA/HOTPLUG: clear buffer-head lru before page migration The bh must be free to migrate