Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-15 Thread Jesper Nilsson
On Wed, Nov 14, 2007 at 06:29:17PM -0800, Denys Vlasenko wrote: > On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: > > /* Not true gettimeofday, only checks the jiffies (uptime) + useconds */ > > -void __INLINE__ do_gettimeofday_fast(struct fasttime_t *tv) > > +inline void

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-15 Thread Jesper Nilsson
On Wed, Nov 14, 2007 at 06:29:17PM -0800, Denys Vlasenko wrote: On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: /* Not true gettimeofday, only checks the jiffies (uptime) + useconds */ -void __INLINE__ do_gettimeofday_fast(struct fasttime_t *tv) +inline void

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-14 Thread Denys Vlasenko
On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: > Scrap the local __INLINE__ macro, and rename timeval_cmp to fasttime_cmp. > > Inline macro was completely unnecessary since the macro was defined > locally to be inline. > timeval_cmp was inaccurately named since it does comparison on >

[PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-14 Thread Jesper Nilsson
Scrap the local __INLINE__ macro, and rename timeval_cmp to fasttime_cmp. Inline macro was completely unnecessary since the macro was defined locally to be inline. timeval_cmp was inaccurately named since it does comparison on struct fasttimer_t and not on struct timeval. Signed-off-by: Jesper

[PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-14 Thread Jesper Nilsson
Scrap the local __INLINE__ macro, and rename timeval_cmp to fasttime_cmp. Inline macro was completely unnecessary since the macro was defined locally to be inline. timeval_cmp was inaccurately named since it does comparison on struct fasttimer_t and not on struct timeval. Signed-off-by: Jesper

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-14 Thread Denys Vlasenko
On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: Scrap the local __INLINE__ macro, and rename timeval_cmp to fasttime_cmp. Inline macro was completely unnecessary since the macro was defined locally to be inline. timeval_cmp was inaccurately named since it does comparison on struct