Re: [PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

2014-06-16 Thread Jörn Engel
On Mon, 16 June 2014 20:46:32 -0400, Nick Krause wrote: > > You are right about the compile errors it compiles but with warning. > I am curious since the function is void how do you want me to > give the error back to logfs and in turn the other subsystems > of the kernel. My first question

Re: [PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

2014-06-16 Thread Mateusz Guzik
On Mon, Jun 16, 2014 at 03:47:01PM -0400, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause > --- > fs/logfs/readwrite.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/logfs/readwrite.c b/fs/logfs/readwrite.c > index 4814031..adb9233 100644 > --- a/fs/logfs/readwrite.c >

[PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

2014-06-16 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- fs/logfs/readwrite.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/logfs/readwrite.c b/fs/logfs/readwrite.c index 4814031..adb9233 100644 --- a/fs/logfs/readwrite.c +++ b/fs/logfs/readwrite.c @@ -2210,6 +2210,8 @@ void btree_write_block(struct

[PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

2014-06-16 Thread Nicholas Krause
Signed-off-by: Nicholas Krause xerofo...@gmail.com --- fs/logfs/readwrite.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/logfs/readwrite.c b/fs/logfs/readwrite.c index 4814031..adb9233 100644 --- a/fs/logfs/readwrite.c +++ b/fs/logfs/readwrite.c @@ -2210,6 +2210,8 @@ void

Re: [PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

2014-06-16 Thread Mateusz Guzik
On Mon, Jun 16, 2014 at 03:47:01PM -0400, Nicholas Krause wrote: Signed-off-by: Nicholas Krause xerofo...@gmail.com --- fs/logfs/readwrite.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/logfs/readwrite.c b/fs/logfs/readwrite.c index 4814031..adb9233 100644 ---

Re: [PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block

2014-06-16 Thread Jörn Engel
On Mon, 16 June 2014 20:46:32 -0400, Nick Krause wrote: You are right about the compile errors it compiles but with warning. I am curious since the function is void how do you want me to give the error back to logfs and in turn the other subsystems of the kernel. My first question would be: