[PATCH] Consolidate compat_sys_waitid

2005-03-06 Thread Stephen Rothwell
Hi Andrew, Linus, This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid syscalls to ppc64 I have left PARISC and MIPS to their own

[PATCH] Consolidate compat_sys_waitid

2005-03-06 Thread Stephen Rothwell
Hi Andrew, Linus, This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid syscalls to ppc64 I have left PARISC and MIPS to their own

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-17 Thread Stephen Rothwell
On Tue, 15 Feb 2005 18:43:07 + Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: > > > +asmlinkage long compat_sys_waitid(u32 which, u32 pid, > > + struct compat_siginfo __user *uinfo, u32 options, > > + struct

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-17 Thread Stephen Rothwell
On Tue, 15 Feb 2005 18:43:07 + Matthew Wilcox [EMAIL PROTECTED] wrote: On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: +asmlinkage long compat_sys_waitid(u32 which, u32 pid, + struct compat_siginfo __user *uinfo, u32 options, + struct

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Paul Mackerras
Stephen Rothwell writes: > This patch does: > - consolidate the three implementations of compat_sys_waitid > (some were called sys32_waitid). > - adds sys_waitid syscall to ppc > - adds sys_waitid and compat_sys_waitid syscalls to ppc64 Looks good to me. Are you going

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Daniel Jacobowitz
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: > Hi all, > > This patch does: > - consolidate the three implementations of compat_sys_waitid > (some were called sys32_waitid). > - adds sys_waitid syscall to ppc > - adds sys_waitid and compat_sys_waitid

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Al Viro
On Tue, Feb 15, 2005 at 08:23:41PM +0100, Andi Kleen wrote: > > The reason it isn't in Linus' tree yet is that it depends on the > > is_compat_task() predicate which Andi vetoed out of Andrew's tree. > > As a result, I haven't been able to merge any of the compat stuff > > sitting in the PA tree.

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Andi Kleen
> The reason it isn't in Linus' tree yet is that it depends on the > is_compat_task() predicate which Andi vetoed out of Andrew's tree. > As a result, I haven't been able to merge any of the compat stuff > sitting in the PA tree. A few more voices in favour of reintroducing > is_compat_task()

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Matthew Wilcox
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: > Parisc seemed to assume th existance of compat_sys_waitid. PA-RISC already has a compat_sys_waitid ;-P The reason it isn't in Linus' tree yet is that it depends on the is_compat_task() predicate which Andi vetoed out of Andrew's

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread David S. Miller
On Tue, 15 Feb 2005 14:01:49 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > This patch does: > - consolidate the three implementations of compat_sys_waitid > (some were called sys32_waitid). > - adds sys_waitid syscall to ppc > - adds sys_waitid and

RE: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Luck, Tony
>This patch does: > - consolidate the three implementations of compat_sys_waitid > (some were called sys32_waitid). > - adds sys_waitid syscall to ppc > - adds sys_waitid and compat_sys_waitid syscalls to ppc64 > >Parisc seemed to assume th existance of

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Andi Kleen
On Tue, Feb 15, 2005 at 10:06:14PM +1100, Stephen Rothwell wrote: > Hi Andi, > > On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > I don't think this will work for sparc64/s390/UML etc. > > They cannot access kernel data inside KERNEL_DS. You would need to use > >

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Stephen Rothwell
Hi Andi, On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > I don't think this will work for sparc64/s390/UML etc. > They cannot access kernel data inside KERNEL_DS. You would need to use > compat_alloc_user_space() for ru .. and, presumably, for info as well.

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Andi Kleen
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: > +asmlinkage long compat_sys_waitid(u32 which, u32 pid, > + struct compat_siginfo __user *uinfo, u32 options, > + struct compat_rusage __user *uru) > +{ > + siginfo_t info; > + struct rusage ru; > +

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Andi Kleen
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: +asmlinkage long compat_sys_waitid(u32 which, u32 pid, + struct compat_siginfo __user *uinfo, u32 options, + struct compat_rusage __user *uru) +{ + siginfo_t info; + struct rusage ru; +

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Stephen Rothwell
Hi Andi, On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen [EMAIL PROTECTED] wrote: I don't think this will work for sparc64/s390/UML etc. They cannot access kernel data inside KERNEL_DS. You would need to use compat_alloc_user_space() for ru .. and, presumably, for info as well. Interestingly,

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Andi Kleen
On Tue, Feb 15, 2005 at 10:06:14PM +1100, Stephen Rothwell wrote: Hi Andi, On Tue, 15 Feb 2005 10:51:53 +0100 Andi Kleen [EMAIL PROTECTED] wrote: I don't think this will work for sparc64/s390/UML etc. They cannot access kernel data inside KERNEL_DS. You would need to use

RE: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Luck, Tony
This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid syscalls to ppc64 Parisc seemed to assume th existance of compat_sys_waitid. The

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread David S. Miller
On Tue, 15 Feb 2005 14:01:49 +1100 Stephen Rothwell [EMAIL PROTECTED] wrote: This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Matthew Wilcox
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: Parisc seemed to assume th existance of compat_sys_waitid. PA-RISC already has a compat_sys_waitid ;-P The reason it isn't in Linus' tree yet is that it depends on the is_compat_task() predicate which Andi vetoed out of Andrew's

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Andi Kleen
The reason it isn't in Linus' tree yet is that it depends on the is_compat_task() predicate which Andi vetoed out of Andrew's tree. As a result, I haven't been able to merge any of the compat stuff sitting in the PA tree. A few more voices in favour of reintroducing is_compat_task() would

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Al Viro
On Tue, Feb 15, 2005 at 08:23:41PM +0100, Andi Kleen wrote: The reason it isn't in Linus' tree yet is that it depends on the is_compat_task() predicate which Andi vetoed out of Andrew's tree. As a result, I haven't been able to merge any of the compat stuff sitting in the PA tree. A few

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Daniel Jacobowitz
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: Hi all, This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Paul Mackerras
Stephen Rothwell writes: This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid syscalls to ppc64 Looks good to me. Are you going to

[PATCH] Consolidate compat_sys_waitid

2005-02-14 Thread Stephen Rothwell
Hi all, This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid syscalls to ppc64 Parisc seemed to assume th existance of

[PATCH] Consolidate compat_sys_waitid

2005-02-14 Thread Stephen Rothwell
Hi all, This patch does: - consolidate the three implementations of compat_sys_waitid (some were called sys32_waitid). - adds sys_waitid syscall to ppc - adds sys_waitid and compat_sys_waitid syscalls to ppc64 Parisc seemed to assume th existance of